Skip to content

build(deps): resolve dependency security advisories - #106

Merged
ammario merged 1 commit into
mainfrom
security/dependency-alerts
Sep 24, 2026
Merged

ammario merged 1 commit into
mainfrom
security/dependency-alerts

Conversation

@ammar-agent

@ammar-agent ammar-agent commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #105. Update the locked dependency graph to remediate all 12 currently open Dependabot alerts, plus additional findings from a fresh RustSec audit. No advisories are dismissed or suppressed.

The code change is limited to replacing macOS atty usage with std::io::IsTerminal; proxy, policy, and jail behavior are otherwise unchanged by application code.

Alert coverage

Numbers below refer to Dependabot alerts, not issue numbers. Versions are the resolved Cargo.lock versions.

Dependency Before → after Alerts / scope
aws-lc-sys (via aws-lc-rs) 0.30.0 → 0.45.0 8, 9, 10, 11 — TLS crypto dependency
rustls-webpki 0.103.4 → 0.103.15 13, 15, 16, 18 — certificate/CRL validation
time 0.3.41 → 0.3.55 7 — certificate generation dependency
lru 0.12.5 → 0.18.5 5 — certificate cache; also fixes a newer panic-safety advisory
rand 0.8.5 → 0.8.8 17 — runtime and build dependency
protobuf (via pprof 0.15) 2.28.0 → 3.7.2 4 — benchmark profiling only

Also update rustls, h2, and crossbeam-epoch for additional RustSec vulnerabilities; update anyhow/memmap2 and remove vulnerable scc via serial_test 3.5 for unsoundness advisories. Remove atty entirely. Other lockfile changes are supporting dependencies of these targeted upgrades, not a blanket refresh.

Review notes / remaining risks

  • Review Cargo.toml first for the raised version floors, then Cargo.lock. lru and benchmark-only pprof cross pre-1.0 minor versions; the existing cache API still compiles, and protobuf profile generation is exercised below. pprof retains its protobuf codec and pure-Rust code generation; no system protoc dependency is introduced.
  • These include native AWS-LC and TLS validation updates, so upstream security behavior can change even though proxy code does not.
  • time now declares Rust 1.88+. The project already uses let-chains requiring 1.88; validation uses current stable, not a separately verified minimum toolchain.
  • RustSec still reports two existing maintenance warnings, adler and paste, through unchanged v8 129. They are not vulnerability or unsoundness findings. A V8 upgrade is deferred rather than folded into this security patch.
  • GitHub alerts will remain open until this lands on the default branch and Dependabot rescans; this PR fixes the vulnerable versions instead of dismissing the alerts.

Validation

All six GitHub CI checks passed for 2d7b92d: Linux/macOS Clippy, formatting, unused dependencies, Linux tests, and macOS integrations.

  • Compared every open GitHub alert against the resolved patched version in Cargo.lock.
  • cargo audit 0.22.2: 13 → 0 vulnerabilities, 7 → 0 unsoundness warnings; only the two maintenance warnings above remain.
  • macOS: cargo fmt --check, cargo clippy --locked --all-targets -- -D warnings, full cargo test --locked.
  • Linux, isolated CI-1 checkout: formatting, all-target Clippy, 62 unit tests, 14 weak-mode tests, and 33 privileged integration tests passed (3 helper entry points ignored as standalone tests). Docker and native HTTPS allow/deny cases are included.
  • Linux runtime smoke: native strong-jail HTTPS to https://example.com returned 200 with certificate verification enabled (no -k).
  • Benchmark smoke: cargo bench --locked --profile fast --bench rule_engines -- v8_js_engine --profile-time 1; generated a fresh, nonempty profile.pb.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T16:19:49.250103Z 2d7b92d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ammario
ammario merged commit ff378ae into main Sep 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants