Repository navigation
build(deps): resolve dependency security advisories - #106
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #105. Update the locked dependency graph to remediate all 12 currently open Dependabot alerts, plus additional findings from a fresh RustSec audit. No advisories are dismissed or suppressed.
The code change is limited to replacing macOS
attyusage withstd::io::IsTerminal; proxy, policy, and jail behavior are otherwise unchanged by application code.Alert coverage
Numbers below refer to Dependabot alerts, not issue numbers. Versions are the resolved
Cargo.lockversions.aws-lc-sys(viaaws-lc-rs)rustls-webpkitimelrurandprotobuf(viapprof0.15)Also update
rustls,h2, andcrossbeam-epochfor additional RustSec vulnerabilities; updateanyhow/memmap2and remove vulnerablesccviaserial_test3.5 for unsoundness advisories. Removeattyentirely. Other lockfile changes are supporting dependencies of these targeted upgrades, not a blanket refresh.Review notes / remaining risks
Cargo.tomlfirst for the raised version floors, thenCargo.lock.lruand benchmark-onlypprofcross pre-1.0 minor versions; the existing cache API still compiles, and protobuf profile generation is exercised below.pprofretains its protobuf codec and pure-Rust code generation; no systemprotocdependency is introduced.timenow declares Rust 1.88+. The project already uses let-chains requiring 1.88; validation uses current stable, not a separately verified minimum toolchain.adlerandpaste, through unchangedv8129. They are not vulnerability or unsoundness findings. A V8 upgrade is deferred rather than folded into this security patch.Validation
All six GitHub CI checks passed for 2d7b92d: Linux/macOS Clippy, formatting, unused dependencies, Linux tests, and macOS integrations.
Cargo.lock.cargo audit0.22.2: 13 → 0 vulnerabilities, 7 → 0 unsoundness warnings; only the two maintenance warnings above remain.cargo fmt --check,cargo clippy --locked --all-targets -- -D warnings, fullcargo test --locked.https://example.comreturned 200 with certificate verification enabled (no-k).cargo bench --locked --profile fast --bench rule_engines -- v8_js_engine --profile-time 1; generated a fresh, nonemptyprofile.pb.