Repository navigation
Author automation PR commits as github-actions[bot] - #1902
mrbobbytables wants to merge 1 commit into
Conversation
create-pull-request defaults the commit author to the workflow actor, so a maintainer who dispatches a refresh lane by hand ends up as the author of the resulting commit and cannot approve it under the default-branch ruleset's unattributed-changes rule. #1901 is stuck that way. Scheduled runs were unaffected because their actor is already a bot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
9438dd5
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @mrbobbytables, head
Hive did not add the |
|
Closing: the premise was wrong. #1901 merged at 17:26:47Z, immediately after the approving review and re-enqueue; the BLOCKED state I read was stale. The approval is what the ruleset wanted, and the author pin is not needed. |
Remit: generated-data refresh lane is unmergeable when dispatched by hand.
peter-evans/create-pull-requestdefaults the commit author togithub.actor, so a maintainer who runsrefresh-metrics.yml(or any lane usingopen-automation-pr) viaworkflow_dispatchbecomes the author of the automation commit. The default-branch ruleset setsrequire_extra_approval_for_unattributed_changes, so that maintainer's approval does not count and the PR sitsBLOCKEDwith no path to the merge queue short of a second maintainer. #1901 is in that state now; scheduled runs (for example #1441, authored bygithub-merge-queue[bot]) were never affected.Pin
authorin the composite action togithub-actions[bot], which matches the committer the action already uses and the identity scheduled runs produce.After this merges I will re-dispatch
refresh-metrics.yml, merge the new data PR, and close #1901. Refs #1856.