Skip to content

Feature request: person tracking #53

Open

Description

@skuro

In order to use the person tracking Rollbar feature, a person key is sent along with the payload. There's currently a TODO on it in the codebase on the subject.

Activity

  1. skuro commented on Sep 27, 2021

    @skuro
    ContributorAuthor

    My proposal is to add an optional argument to make-rollbar so that it can actually propagate the person data. I'll try to come up with a rough PR to explain my concept a bit better, but something along the lines of

    (defn notify
      "Report an exception to Rollbar."
      ([^String level client ^Throwable exception]
       (notify level client exception {}))
      ([^String level {:keys [result-fn send-fn block-fields] :as client} ^Throwable exception {:keys [url params person]}] ;; <-- here!
       ..same as before..))
  2. added a commit that references this issue on Sep 27, 2021
    bf911de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions