Skip to content

LOC-1636 Detect Alpine linux and download specific binary - #111

Merged
bipul21 merged 10 commits into
browserstack:masterfrom
AdityaHirapara:LOC-1636_Alpine_binary
Sep 1, 2020
Merged

bipul21 merged 10 commits into
browserstack:masterfrom
AdityaHirapara:LOC-1636_Alpine_binary

Conversation

@AdityaHirapara

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread lib/LocalBinary.js

@Raj-7799 Raj-7799 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case for LocalBinary() and verify the httpPath

Comment thread lib/LocalBinary.js Outdated

@Raj-7799 Raj-7799 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants