Skip to content

Remove node: prefix from imports - #3584

Merged
brianc merged 2 commits into
masterfrom
bmc/remove-node-require
Jan 20, 2026
Merged

brianc merged 2 commits into
masterfrom
bmc/remove-node-require

Conversation

@brianc

@brianc brianc commented Jan 20, 2026 •

Copy link
Copy Markdown
Owner

Closes #3583
Closes #3581

It's debatable the failure to import from node:* in cloudflare or vitest is something that could be fix on that side, but it's zero skin off my nose to just not use node:* imports at all. Might as well make things as easy as possible!

@brianc
brianc requested a review from hjr3 as a code owner January 20, 2026 17:53
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jan 20, 2026 •

Copy link
Copy Markdown

Deploying node-postgres with  Cloudflare Pages  Cloudflare Pages

Latest commit: af38643
Status: ✅  Deploy successful!
Preview URL: https://747f98ca.node-postgres.pages.dev
Branch Preview URL: https://bmc-remove-node-require.node-postgres.pages.dev

View logs

@brianc
brianc merged commit ea06db5 into master Jan 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New version breaks in cloudflare vitests: No such module "node:process" uncaughtException: Cannot find module 'node:process

1 participant