You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Examples removed from fmXXDecomp.R manual pages, and saved for future replacement #58
Manual page examples to be removed from factor model risk decomposition
functions for now, due to removal of data sets for the examples, and saved
here for adding back once new data sets are provided for these examples
#' data(Stocks.df)
#' exposure.vars <- c("BOOK2MARKET", "LOG.MARKETCAP", "GICS.SECTOR")
#' fit2 <- fitFfm(data=stock, asset.var="TICKER", ret.var="RETURN",
#' date.var="DATE", exposure.vars=exposure.vars)
#'
#' # summary of factor returns estimated in each time period
#' summary(fit2)
#'
#' # summary of lm fit for a single period
#' summary(fit2$factor.fit[[1]])
On Sun, Sep 12, 2021 at 5:27 PM Justin M. Shea ***@***.***> wrote:
@martinrd3D <https://github.com/martinrd3D> we could replace the
stocks.df and other legacy data sets with something like this:
data("stocksCRSP")
data("scoresSPGMI")
CRSP_SPGMI <- merge(stocksCRSP, scoresSPGMI,
by = intersect( names(stocksCRSP), names(scoresSPGMI) )
)
Let me know what you think
Justin,
Conceptually, it makes sense, keeping in mind that stocks.df is 447 stocks
by 8 years, whereas stocksCRSP is 300 stocks
by 20 years, See Sangeetha's fitFfm vignette, which in case you don't have
it handy, I have attached. But the more relevant
point is that we are quite unlikely to bother with that vignette in view of
the broader and deeper one we have that uses fitFfmDT.
The more relevant place where we could use stocksCRSP is for the
StockReturns object monthly stock returns r.M and weekly stock returns r.W
for fitSfm, as in Sangeetha's fitSfm vignette, and we definitely want to
resurrect that later.
Doug
It is not a good idea to remove current examples because the example may be
fine
with a data replacement and/or code replacement, but still illustrating the
same thing.
If I don't have the example, then I have to create one with no idea what
the original
example was trying to show.
Activity
fix various code issues to run the example files.
JustinMShea commentedon Sep 13, 2021
@martinrd3D we could replace the stocks.df and other legacy data sets with something like this:
Let me know what you think
martinrd3D commentedon Sep 13, 2021
martinrd3D commentedon Dec 22, 2021
martinrd3D commentedon Dec 22, 2021
Merge pull request #82 from kecoli/master