Repository navigation
Expose additional BoxAPIRequest/BoxAPIConnection members for request intercept use case #488
Description
Activity
Hey @timvossen — could you tell us a bit more about your use case here? It would help us to know exactly what you're trying to do with the request interceptor so we can prioritize and evaluate the necessary access changes.
@mattwiller
The use case was to send the actual HTTP requests via an Apache HTTP client instead of the HttpURLConnection that is built into the SDK. This leads to increased robustness regarding connection resets and read timeouts, as that HTTP client can do retries in those scenarios.It was my understanding that this use case should be supported for implementations of
RequestInterceptor.@timvossen I'm not totally sure if that's a use case we'll be able to support at the moment — it seems a bit strange to make essentially the entire
BoxAPIConnectionobject public so that an end user could basically reimplement the core request logic of the SDK. BothlockAccessToken()andunlockAccessToken()are really implementation details of the connection, which should probably not be exposed.As far as I can tell, the
RequestInterceptorwas never intended to solve this sort of use case — which is why it runs entirely before the lock on the access token is grabbed by theBoxAPIRequest. The whole idea, as best I can tell from the documentation, was to either modify or inspect the request, and optionally return a different response instead of contacting the Box API. Your use case, as stated, seems out of line with what the feature is designed to provide. I'll add better support for this use case to our backlog for the next major version of the SDK so we don't lose track of it, but I don't think it's something we'll be able to support well today.In any case, the current version of the SDK should be retrying on connection errors and read timeouts — can you share a bit more about what problems you're seeing around those so we can see if there's a better way for us to address it in the SDK?
In a Box SDK integration, I implemented a
com.box.sdk.RequestInterceptorthat uses its own HTTP client to send the requests over the network. Doing that, I noticed that in order to support this scenario, certain members should, in my opinion, be exposed to clients outside the SDK:com.box.sdk.BoxAPIRequest.getHeaders()should be public so that the corresponding content is accessiblecom.box.sdk.BoxAPIRequest.shouldAuthenticateshould be exposed via a getter to distinguish the two cases that it indicatesIn order to hold a read lock on the access token during the request (as
com.box.sdk.BoxAPIRequest.trySend(ProgressListener)does), it would be necessary to also exposecom.box.sdk.BoxAPIConnection.lockAccessToken()andcom.box.sdk.BoxAPIConnection.unlockAccessToken().The access token can be obtained with the (already public) method
com.box.sdk.BoxAPIConnection.getAccessToken(), but in this case there is no lock and the access token could be invalidated before the HTTP request is sent (or while it is being sent).