Skip to content

8.9.255.9 - #45

Merged
bnoordhuis merged 3 commits into
masterfrom
8.9
Mar 24, 2021
Merged

bnoordhuis merged 3 commits into
masterfrom
8.9

Conversation

@bnoordhuis

Copy link
Copy Markdown
Owner

No description provided.

@gengjiawen

Copy link
Copy Markdown
Collaborator

Upstream: https://chromium-review.googlesource.com/c/v8/v8/+/2711152

Original commit message:

    Fixes compilation with msvc 2019 toolchain.
@bnoordhuis

Copy link
Copy Markdown
Owner Author

@gengjiawen I don't really have time at the moment to investigate and push this through but if you want to pick up where I left off, I'm happy to make you co-maintainer.

@gengjiawen

gengjiawen commented Mar 15, 2021 •

Copy link
Copy Markdown
Collaborator

@gengjiawen I don't really have time at the moment to investigate and push this through but if you want to pick up where I left off, I'm happy to make you co-maintainer.

Sure :)

@bnoordhuis

Copy link
Copy Markdown
Owner Author

@gengjiawen No pressure at all but I was wondering if you managed to make any progress on this? You received (and accepted) the invitation, right?

@gengjiawen

Copy link
Copy Markdown
Collaborator

@gengjiawen No pressure at all but I was wondering if you managed to make any progress on this?

Not fully into it. Looks like this part not working

if(WIN32)
  list(APPEND heap-sources
    $<${is-arm64}:v8/src/heap/base/asm/arm64/push_registers_masm.S>
    $<${is-ia32}:v8/src/heap/base/asm/ia32/push_registers_masm.S>
    $<${is-x64}:v8/src/heap/base/asm/x64/push_registers_masm.S>
  )

You received (and accepted) the invitation, right?

Yeap.

@gengjiawen

Copy link
Copy Markdown
Collaborator

@bnoordhuis looks build passed.

@bnoordhuis
bnoordhuis merged commit 9075563 into master Mar 24, 2021
@bnoordhuis

Copy link
Copy Markdown
Owner Author

Sweet, merged. You want to try to do the next upgrade?

MBeijer added a commit to MBeijer/v8-mingw64 that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants