Repository navigation
feat(desktop): nest channel sections one level deep - #8356
Draft
s-kikeriki wants to merge 1 commit into
Draft
s-kikeriki wants to merge 1 commit into
s-kikeriki wants to merge 1 commit into
Conversation
🔐 Codex Security Review
|
Sections in the sidebar were a flat list. This adds subsections: a section can hold other sections one level down, with their own channels, order and icons. A section carries a `parent` register in the existing kind 30078 lane, so nesting syncs across devices and survives a reinstall like the rest of the sidebar state. The projection caps the tree at two levels and treats a parent that is missing, deleted, self-referential or already nested as "no parent", so a corrupt or newer-client document degrades to a flat list instead of hiding channels. The legacy payload older clients read gains a `parentId` field; clients that ignore it keep rendering the sections flat. UI: "New subsection..." on a top-level section, "Move out of subsection" on a nested one, both in the ⋮ menu and the header context menu. Subsections indent under their parent, collapse with it, and roll their unread and "Mark all as read" up into it. "Move to section" lists them indented, with the parent spelled out in the accessible name. Only top-level sections take part in drag reordering; a subsection reorders within its siblings. Tests: projection rules (depth cap, cycles, orphan promotion, assignments), hook guards, and a Playwright spec that creates a subsection, moves a channel into it and reloads. Signed-off-by: Support Kikeriki <support@kikeriki.net>
s-kikeriki
force-pushed
the
feat/desktop-nested-channel-sections
branch
from
October 15, 2026 10:27
b5f254e to
9735187
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
Sidebar sections are a flat list today. This lets a section hold other sections one
level down, each with their own channels, order and icon.
Closest existing issue: #5738 (the original custom sections request). No open issue or
PR asks for nesting specifically — I searched issues and PRs for "subsection", "nested
section" and sidebar section titles before starting. Happy to convert this to an issue
first if you would rather agree the direction before reviewing code.
How it works
parentregister in the existing kind 30078 lane, so nestingsyncs across devices and survives a reinstall like the rest of the sidebar state.
No new event kind.
deleted, self-referential or already nested as "no parent". A corrupt document, or
one written by a newer client, degrades to a flat list rather than hiding channels.
parentIdfield. Clients that ignoreit keep rendering every section flat, so this is additive on the wire.
UI
one, both in the ⋮ menu and the header context menu.
and "Mark all as read" up into it.
accessible name.
its siblings.
Trade-offs
projection rules small enough to reason about; arbitrary depth would need cycle
handling on every read path.
mobile can pick it up separately.
How to test manually
Tests
Deferred
Screenshot
"Clients" holds #random, with "Kalte Herberge" and "Schweizerhof" nested under it,
each with their own channels.