Repository navigation
Conversation
Signed-off-by: BOLTy - Ignition Engine <a7c9f0cdb973190a49ac5668740df77bb1675909838209695f9b0f7a56d60ed8@buzz.atlbitlab.com>
🔐 Codex Security Review
|
Signed-off-by: BOLTy - Ignition Engine <a7c9f0cdb973190a49ac5668740df77bb1675909838209695f9b0f7a56d60ed8@buzz.atlbitlab.com>
Signed-off-by: Stephen DeLorme <stephen@d.elor.me> (cherry picked from commit c8c20c3)
Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent teams can mention one another indefinitely because buzz-acp currently relies on prompt instructions to stop loops. This adds an opt-in
BUZZ_ACP_TEAM_PUBKEYSguard: six consecutive teammate-directed triggers are allowed, then later teammate triggers are dropped until an admitted human posts in the same scope. Top-level channel posts share one channel counter; replies use their canonical thread root. Edits and an agent's own team-directed posts count. Human-triggered turns always run.A reset requires an admitted effective author who is the bound owner or explicitly allowlisted, a direct signer (not a relay-signed workflow), a non-bot channel role, and no NIP-OA profile tag. The role/profile verdict is cached per author and channel for 60 seconds. A customer-allowlisted Kettle agent with a plain
memberrole and no NIP-OA profile tag counts as human for resets. The counter is in memory, so a process restart permits another six turns.The same patch makes the ACP permission-mode setup timeout configurable with
BUZZ_ACP_PERMISSION_MODE_TIMEOUTwhile retaining the five-second default. Hosted cold starts can set a longer value without changing everyone else.Validation:
cargo fmt --all --check,cargo clippy -p buzz-acp --lib --tests -- -D warnings, and the full supportedbuzz-acppackage suite pass on this head (1,073 library tests passed, three ignored). Two native-Git credential bootstrap tests fail atgit credential fillon the pre-patch base under local Git 2.39.1 and were excluded from the supported run. Behavioral tests cover alternating top-level posts, rejected and allowed resets, self-counting, edits, cache expiry, and configured permission-mode behavior. Six mutations were run and caught: disabled drop gate, pre-authorization reset, unconditional reset, disabled self-counting, and hard-coded timeouts in runtime or pool.This PR remains draft pending human runtime validation.