Skip to content

Remove the extra coverage file support. #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keith merged 1 commit into from
May 27, 2026
Merged

Remove the extra coverage file support. #2973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions apple/internal/rule_factory.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,6 @@ AppleTestRunnerInfo provider.
aspects = [coverage_files_aspect],
providers = [AppleBundleInfo],
),
"_apple_coverage_support": attr.label(
cfg = config.exec(exec_group = "test"),
default = Label("@build_bazel_apple_support//tools:coverage_support"),
),
"_lcov_merger": attr.label(
default = configuration_field(
fragment = "coverage",
Expand Down
2 changes: 0 additions & 2 deletions apple/internal/testing/apple_test_rule_support.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,6 @@ def _apple_test_rule_impl(*, ctx, requires_dossiers, test_type):
if test_coverage_manifest:
direct_runfiles.append(test_coverage_manifest)

apple_coverage_support_files = ctx.attr._apple_coverage_support.files
covered_binaries = test_bundle_target[_CoverageFilesInfo].covered_binaries

execution_environment = dicts.add(
Expand All @@ -348,7 +347,6 @@ def _apple_test_rule_impl(*, ctx, requires_dossiers, test_type):
)

transitive_runfiles.extend([
apple_coverage_support_files,
covered_binaries,
test_bundle_target[_CoverageFilesInfo].coverage_files,
])
Expand Down