Skip to content

Update tests #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JLHwung merged 7 commits into from
Jun 20, 2024
Merged

Update tests #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4a5476
remove ESLint rule covered in eslint:recommended
JLHwung Jul 28, 2023
d1ea132
Use promises in test cases
JLHwung Jul 28, 2023
5a861f6
add node 20 to CI jobs
JLHwung Jul 28, 2023
2223414
test: remove isWebpack5 helper
JLHwung Jul 28, 2023
23b50d4
find fixture basic index at runtime
JLHwung Jul 28, 2023
d7cf874
fixup merge conflict
JLHwung Jun 16, 2024
4f474c8
use nm as node linker
JLHwung Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parser": "@babel/eslint-parser",
"extends": ["eslint:recommended", "eslint-config-prettier"],
"parserOptions": {
"ecmaVersion": 2017,
"ecmaVersion": "latest",
"sourceType": "module"
},
"rules": {
Expand All @@ -12,7 +12,6 @@
"linebreak-style": ["error", "unix"],
"max-len": ["error", 110, 2],
"new-cap": "off",
"no-case-declarations": "error",
"no-cond-assign": "off",
"no-confusing-arrow": "error",
"no-console": "off",
Expand All @@ -28,8 +27,6 @@
"no-underscore-dangle": "off",
"no-unreachable": "off",
"no-use-before-define": "off",
"no-var": "error",
"prefer-const": "error",
"strict": "off",
"prettier/prettier": "error"
},
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest]
node-version: [14, 16, 18, 20]
webpack-version: ['5']
webpack-version: ["5"]
include:
- node-version: "14.15.0" # The minimum supported node version
webpack-version: latest
webpack-version: "5.0.0" # The minimum supported webpack version
os: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -24,7 +24,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
cache: "yarn"
- name: Install dependencies
run: yarn
- name: Install webpack ${{ matrix.webpack-version }}
Expand All @@ -47,7 +47,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
cache: "yarn"
- name: Install dependencies
run: yarn
- name: Run lint and coverage tests
Expand All @@ -56,4 +56,3 @@ jobs:
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}

3 changes: 2 additions & 1 deletion .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
yarnPath: .yarn/releases/yarn-3.6.4.cjs
nodeLinker: node-modules
yarnPath: .yarn/releases/yarn-3.6.4.cjs
Loading