Skip to content

Improve installing bundler dependencies - #13

Open
viktorianer wants to merge 2 commits into
fix/dev-containers-clifrom
improvement/installing-bundler-dependencies
Open

viktorianer wants to merge 2 commits into
fix/dev-containers-clifrom
improvement/installing-bundler-dependencies

Conversation

@viktorianer

Copy link
Copy Markdown
Collaborator

A new volume has been introduced for bundler dependencies. While PR rails/devcontainer#48 addresses the same issue, this implementation is simpler.

Steps to reproduce with Reinstalling Bundler Dependencies

  • Run devcontainer --workspace-folder . up multiple times.

Expected behavior with Reinstalling Bundler Dependencies

  • Stop the running Docker project.
  • Run devcontainer --workspace-folder . up.
  • Bundler should recognize that dependencies are already installed and not reinstall them.
...
== Installing dependencies ==
The Gemfile's dependencies are satisfied
yarn install v1.22.22
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.56s.
...

Actual behavior with Reinstalling Bundler Dependencies

  • Stop the running Docker project.
  • Run devcontainer --workspace-folder . up.
  • Bundler reinstalls dependencies that were previously installed.
> devcontainer --workspace-folder . up
...
== Installing dependencies ==
https://github.com/rails/rails.git (at main@3ebff69) is not yet checked out. Run `bundle install` first.
...
Fetching gem metadata from https://rubygems.org/.
...
Fetching https://github.com/rails/rails.git
Fetching rake 13.2.1
Installing rake 13.2.1
...
Bundle complete! 23 Gemfile dependencies, 121 gems now installed.
...
yarn install v1.22.22
[1/4] Resolving packages...
success Already up-to-date.
...

@viktorianer
viktorianer changed the base branch from main to fix/dev-containers-cli October 2, 2024 11:07
Bundler should recognize that dependencies are already installed and not reinstall them.
@viktorianer
viktorianer force-pushed the improvement/installing-bundler-dependencies branch from 5963fa6 to fa5c225 Compare October 3, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant