Repository navigation
[ISSUE 38] Add nodeAffinity for nameService pod - #75
Closed
shendongsd wants to merge 4 commits into
Closed
shendongsd wants to merge 4 commits into
shendongsd wants to merge 4 commits into
Conversation
caigy
approved these changes
Aug 24, 2021
Contributor
|
@shendongsd Is there an issue related to this PR? Would you also support |
Author
|
caigy
requested changes
Aug 30, 2021
caigy
left a comment
Contributor
There was a problem hiding this comment.
- I think abbreviations like
reqDurSchIgnDurExeare not no clear, especially for new beginners of K8s. For example, 'req' is short for 'request' in most cases other than 'require'. I think it more clear to leave the full names defined in K8s. - Could you provide the reason to remove
go.mod? I don't think this deletion is related to the issue.
Author
1、I changed the variable name and restored "go.mod" |
Member
|
the user should be able to just mention the nodeAffinity in the CR, templating out each and every spec in the nodeAffinity, isn't a best practice in the operator. this is only needed in the CR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.