Skip to content

[ISSUE #119] Add event resource permission - #118

Merged
caigy merged 1 commit into
apache:masterfrom
gobbq:bugfix/add-event-resource-permission
Jul 28, 2022
Merged

caigy merged 1 commit into
apache:masterfrom
gobbq:bugfix/add-event-resource-permission

Conversation

@gobbq

@gobbq gobbq commented Jul 28, 2022 •

Copy link
Copy Markdown

Event resource permission is missing, operator logs as follows:

image

ref issue #119

@gobbq gobbq changed the title [BugFix] Add event resource permission [ISSUE 119] Add event resource permission Jul 28, 2022
@caigy caigy changed the title [ISSUE 119] Add event resource permission [ISSUE #119] Add event resource permission Jul 28, 2022
@caigy
caigy merged commit b989e6f into apache:master Jul 28, 2022
@caigy caigy linked an issue Jul 28, 2022 that may be closed by this pull request

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Adds missing RBAC permissions for Kubernetes events resource (create and patch verbs) to both the deploy manifest (role.yaml) and the kubebuilder marker in main.go.

This is a correct and minimal fix — the operator needs to create Event resources for status reporting, and the RBAC rules were missing this permission, causing the operator to log errors when attempting to publish events.

LGTM.


Automated review by github-manager-bot

@RockteMQ-AI

Copy link
Copy Markdown

Issue Evaluation

Category: bug | Status: Confirmed

The operator's RBAC configuration is missing the events resource permission. Without it, the operator cannot create or update Kubernetes Events, which are used for observability and debugging.

Root Cause: The ClusterRole definition does not include events in its resources list. When the operator attempts to record events (e.g., during reconciliation), the Kubernetes API server rejects the request with a forbidden error.

Fix: Add events to the ClusterRole's resources list:

- apiGroups: [""]
  resources: ["events"]
  verbs: ["create", "get", "list", "watch", "update", "patch"]

Note: This issue has been open since Dec 2022 and marked stale. Related to #119. The fix is straightforward.


Automated evaluation by github-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event resource permission is missing

3 participants