Repository navigation
feat(converters): add native ClickHouse SQL dialect converter (#546) - #548
MahmoudHassanen99 wants to merge 2 commits into
Conversation
|
Thank you for your first contribution to Apache Ossie (incubating)! A committer will review your PR. In the meantime, please ensure:
No ICLA is required to contribute. If you are elected as a committer in the future, you will need an Individual Contributor License Agreement (ICLA) on file with the ASF. Questions? Ask in the PR comments or join us on Slack. We appreciate your contribution! |
|
Thanks for the PR. One semantic issue in the aggregate mappings, and a suggestion for the tests.
The tests compare generated SQL strings, so they pass with either function. Running each mapping on a small fixture in ClickHouse and comparing the result with a reference engine such as DuckDB would catch this. |
Apache Ossie's converters are named ossie-<vendor> with a module ossie_<vendor>, and apache/ossie#548 proposes a ClickHouse one under our current name. The package, module, command and MCP server name become dactopus-ossie-clickhouse; the old command stays as an alias with a note on stderr until 0.5.0. OSSIE_CLICKHOUSE_URL keeps its name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apache Ossie's converters are named ossie-<vendor> with a module ossie_<vendor>, and apache/ossie#548 proposes a ClickHouse one under our current name. The package, module, command and MCP server name become dactopus-ossie-clickhouse; the old command stays as an alias with a note on stderr until 0.5.0. OSSIE_CLICKHOUSE_URL keeps its name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… percentile spec (apache#548)
|
Thanks for catching this @ekut, You're completely right |
Summary
This PR introduces a native ClickHouse SQL dialect converter under
converters/clickhouse/as proposed in #546.Key additions:
uniqExact,uniqCombined64,quantileExact).toStartOfDay,toStartOfWeek,toStartOfMonth,toStartOfQuarter,toStartOfYear).nullIf(divisor, 0)guards to prevent division-by-zero exceptions.converters/clickhouse/tests/with 100% test coverage and validated query syntax against a live ClickHouse engine.Related Issues
Closes #546
Checklist
Specification
core-spec/and follow the existing structureOntology
ontology/are consistent with spec changesConverters
converters/is updated to reflect spec or ontology changes.github/labeler.ymlis updated with the new pathValidation
validation/are updated if the spec changedDocumentation
docs/is updated to reflect any user-facing changesCONTRIBUTING.mdis updated if the contribution process changedExamples
examples/are added or updated for any new spec constructs or converter supportTests
pytest/ CI green)Compliance
NOTICEand/orLICENSEhave been updated per ASF policy