Repository navigation
Improve reactor BOM import warning: add coordinates and explain actual risk - #13264
Merged
Merged
Conversation
gnodet-bot
approved these changes
Sep 30, 2026
gnodet-bot
left a comment
There was a problem hiding this comment.
Solid. Warning message now includes BOM coordinates and explains the actual risk (CONSUMER_DEPENDENCY mode skipping conditional profile activation). No logic change, correct API usage, technically accurate description.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
cstamas
approved these changes
Oct 8, 2026
cstamas
left a comment
Member
There was a problem hiding this comment.
and maybe "... and generated BOMs for downstream consumption"
…al risk - Add BOM coordinates (g:a:v) to the warning so the user knows which import is affected - Explain the actual risk: BOM is evaluated in CONSUMER_DEPENDENCY mode, which skips conditional profile activation (file/property/condition), potentially producing an incomplete dependencyManagement compared to the BOM's own build - Suggest parent POM inheritance as the preferred alternative - Mention that downstream consumers of the BOM may be affected as well
gnodet
force-pushed
the
improve/bom-reactor-warning
branch
from
October 14, 2026 14:26
9178dd0 to
50f842e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing warning message
"BOM imports from within reactor should be avoided"is opaque: it doesn't identify which BOM triggered it, doesn't explain why, and gives no actionable guidance.This PR improves the message to:
g:a:v) so the user knows which import is affectedCONSUMER_DEPENDENCYmode, which skips conditional profile activation (file/property/condition activations), potentially producing an incompletedependencyManagementcompared to the BOM's ownBUILD_PROJECTbuildExample new message:
Note: the ordering issue that was the main practical concern (BOM excluded from
-amsubset) is now fixed by #13040.