[goutamadwant]

Summary

• recognize the deprecated org.apache.maven.api.plugin.testing.Basedir annotation while preserving precedence for the replacement annotation
• restore the five-argument constructor on the deprecated ProducedArtifactStub compatibility class
• add regression coverage for the deprecated annotation flow and constructor source compatibility

This keeps the deprecated testing API functional for its remaining lifetime instead of allowing existing plugin tests to compile but silently use the wrong base directory.

Fixes #12678.

Verification

• mvn --batch-mode verify
• mvn --batch-mode -pl impl/maven-testing -am verify
• mvn --batch-mode -pl impl/maven-testing -am -rf :maven-testing -Dtest=ExpressionEvaluatorTest,ProducedArtifactStubTest -Dsurefire.failIfNoSpecifiedTests=false test

Following this checklist to help us incorporate your
contribution quickly and easily:

• Your pull request should address just one issue, without pulling in other changes.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body.
  Note that commits might be squashed by a maintainer on merge.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
  This may not always be possible but is a best-practice.
• Run mvn verify to make sure basic checks pass.
  A more thorough check will be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[gnodet]

Correct, well-scoped fix for issue #12678. The findBasedirValue method follows the exact pattern already established by findInjectMojoAttrs and isRealSession for handling deprecated annotation fallback. The ProducedArtifactStub constructor restoration is also correct. Both changes have targeted regression tests.

Minor note (out of scope for this PR): The same missing-constructor issue exists in the deprecated ArtifactStub shim and in the deprecated SessionStub shim — these represent the same class of bug but are separate fixes.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of gnodet

[gnodet]

Review: Fix deprecated Maven testing API compatibility

Clean, well-scoped compatibility fix that restores deprecated annotation handling for @Basedir and adds the missing 5-arg constructor to the deprecated ProducedArtifactStub shim. Follows the exact pattern already used for @InjectMojo, @MojoTest, and @MojoParameter deprecated fallbacks. All CI checks pass.

The new findBasedirValue method correctly follows the established precedence pattern: check new annotation first, fall back to deprecated annotation, return null/default if neither is found. Test coverage is good — testDeprecatedAnnotations exercises all three deprecated annotations together.

---

This review was generated by an AI agent (Claude Code) and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet