Repository navigation
In failed build limit reactor summary to only failed modules - #12469
Merged
Merged
Conversation
* In failed build limit reactor summary to only failed modules When build fail in multimodule project we need scroll many lines to see whats is wrong based on: apache#11977 (cherry picked from commit 794866c)
gnodet
approved these changes
Jul 11, 2026
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Review Summary
Clean backport of #12330 from master to maven-4.0.x. The diff is byte-for-byte identical to the original merged PR.
Observations:
- The
lastWasSkippedtracking logic correctly handles leading, trailing, and interleaved ellipsis markers between non-adjacent failures - The
formatBuildTimehelper extraction cleanly de-duplicates time formatting - API differences between compat (
getTime()) and impl (getExecTime()) modules are correctly preserved - Four test scenarios cover: single project, successful multimodule, failure multimodule, and separated failures multimodule
- All tests use package-private visibility (JUnit 5 convention) and
lenient()for mocks
LGTM — ready to merge once CI passes.
Claude Code on behalf of Guillaume Nodet
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When build fail in multimodule project we need scroll many lines to see whats is wrong
based on: #11977
(cherry picked from commit 794866c)
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.