Skip to content

In failed build limit reactor summary to only failed modules - #12469

Merged
slawekjaranowski merged 1 commit into
apache:maven-4.0.xfrom
slawekjaranowski:cp-12330
Jul 11, 2026
Merged

slawekjaranowski merged 1 commit into
apache:maven-4.0.xfrom
slawekjaranowski:cp-12330

Conversation

@slawekjaranowski

Copy link
Copy Markdown
Member
  • In failed build limit reactor summary to only failed modules

When build fail in multimodule project we need scroll many lines to see whats is wrong

based on: #11977

(cherry picked from commit 794866c)

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

* In failed build limit reactor summary to only failed modules

When build fail in multimodule project we need scroll many lines to see whats is wrong

based on: apache#11977

(cherry picked from commit 794866c)
@slawekjaranowski slawekjaranowski linked an issue Jul 11, 2026 that may be closed by this pull request
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Jul 11, 2026

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Clean backport of #12330 from master to maven-4.0.x. The diff is byte-for-byte identical to the original merged PR.

Observations:

  • The lastWasSkipped tracking logic correctly handles leading, trailing, and interleaved ellipsis markers between non-adjacent failures
  • The formatBuildTime helper extraction cleanly de-duplicates time formatting
  • API differences between compat (getTime()) and impl (getExecTime()) modules are correctly preserved
  • Four test scenarios cover: single project, successful multimodule, failure multimodule, and separated failures multimodule
  • All tests use package-private visibility (JUnit 5 convention) and lenient() for mocks

LGTM — ready to merge once CI passes.

Claude Code on behalf of Guillaume Nodet
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

@slawekjaranowski
slawekjaranowski merged commit 9568285 into apache:maven-4.0.x Jul 11, 2026
22 checks passed
@slawekjaranowski
slawekjaranowski deleted the cp-12330 branch July 11, 2026 17:41
@github-actions github-actions Bot added this to the 4.0.0-rc-6 milestone Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request mvn40

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNG-7008] skip reactor logging

2 participants