Repository navigation
Feat: Maven 3.x with Resolver 2.x - #11778
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cstamas
marked this pull request as ready for review
March 10, 2026 13:41
Comment on lines
+517
to
+525
| <repositories> | ||
| <repository> | ||
| <snapshots> | ||
| <enabled>false</enabled> | ||
| </snapshots> | ||
| <id>maven-2404</id> | ||
| <url>https://repository.apache.org/content/repositories/maven-2404/</url> | ||
| </repository> | ||
| </repositories> |
Contributor
|
Does this expose 3.10 to #11856? Could not grasp what this is about from a quick read. |
Member
Author
|
This PR updates Maven dependency on Resolver from 1.9.x to 2.0.x. Yes, as Resolver 2.x automatically resolves prefixes (configurable, see But, 3.10.0 GA will use Resolver 2.0.21 (currently on vote) that has this: |
ajreynol
pushed a commit
to ajreynol/cvc5
that referenced
this pull request
Oct 9, 2026
The publication of cvc5 1.4.2 to Maven Central failed ([job](https://github.com/cvc5/cvc5/actions/runs/37712539316/job/113125735442)): ``` Deployment 30d08c38-b120-4a77-b2a3-65b54aa68789 failed - Bundle has content that does NOT have a .pom file: io/github/cvc5/cvc5 ``` **Cause.** Nothing Maven-related changed between 1.4.1 and 1.4.2, but the `ubuntu-24.04` runner image did: Maven went from 3.9.16 (image 20260920.314, used for 1.4.1) to 3.10.0 (image 20261004.327, used for 1.4.2). `central-publishing-maven-plugin` stages the artifacts by installing them into `target/central-staging` (repository id `central-staging`) through Maven's maven-compat installer, then deletes `maven-metadata-central-staging.xml` and zips the directory. In Maven 3.10.0, which uses Maven Resolver 2.x, `LegacyLocalRepositoryManager.overlay()` no longer wraps that directory in a legacy local repository manager but sets up a regular Resolver 2 one (apache/maven#11778), so the installation writes local-repository bookkeeping files instead: `maven-metadata-local.xml` and `_remote.repositories`. The plugin does not remove them, and Central rejects the bundle because `maven-metadata-local.xml` sits in `io/github/cvc5/cvc5/`, next to no `.pom`. The release logs show this: 1.4.0 and 1.4.1 have `Pre Bundling - deleted .../maven-metadata-central-staging.xml`, 1.4.2 does not. The Maven side is reported in apache/maven#13388 (not part of the 3.10.0 release notes' breaking changes). Many other projects hit the same error after the runner image update, and several pinned Maven 3.9.16 as well. This is reproducible with a minimal project and both plugin 0.9.0 (ours) and 0.11.0 (the latest; its release notes do not mention it), so upgrading the plugin does not help: | Maven | Bundle contents | |---|---| | 3.9.16 | `demo-1.0.0.jar`, `demo-1.0.0.pom` | | 3.10.0 | `demo-1.0.0.jar`, `demo-1.0.0.pom`, `maven-metadata-local.xml`, `_remote.repositories` | **Fix.** Install Maven 3.9.16 from Maven Central (verifying its SHA-512) in the "Publish to Maven central" job, instead of using the Maven version of the runner image. The image only ships Maven 3.10.0 (no other version, also not in its tool cache), so a download is needed; it is 9 MB. This is the only job that runs Maven. 1.4.2 was published this way with a one-off workflow, and Central accepted it. The pin can be removed once apache/maven#13388 is fixed or the plugin supports Maven 3.10 (the comment in the workflow links the issue). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Maven 3.x line using Resolver 2.x.
Notable:
Temporary changes applied to ITs on
maven-3.9.x-resolver-2.xbranch:apache/maven-integration-testing#420