Repository navigation
Catching Throwable in non-framework code in PutTaskRequestContent #1988
Description
Affected version: HEAD
File: maven-resolver-transport-jetty/src/main/java/org/eclipse/aether/transport/jetty/PutTaskRequestContent.java:246, 298
} catch (Throwable t) {
lockedSetTerminal(Content.Chunk.from(t, true));
}Catches OutOfMemoryError, StackOverflowError, InternalError, etc. These should propagate. Wrapping them as terminal chunks converts fatal JVM errors into regular failure conditions, making them invisible to diagnostics.
Originally reported in #1944.
Activity
fix: propagate fatal errors from Jetty request content (apache#2161)
elharo commentedon Sep 26, 2026
The fix is incomplete. The code still catches a raw Exception, which is better than Throwable but not what it likely should be doing (unless some method call in its scope is itself broken and declared to throw a raw Exception). This needs to be scoped to what is expected and handled.