[hboutemy]

see apache/maven-sources#57 (comment)

let's maintain only master that produces a Maven 3 plugin being able to generate both Maven 3 plugin descriptors and Maven 4 plugin descriptors

this acts also dropping maven-script and old-Maven 2-style javadoc annotations

[hboutemy]

need to check/clarify Maven 3 plugin.xml generation = https://maven.apache.org/ref/3.9.16/maven-plugin-api/plugin.html
vs Maven 4 one = https://maven.apache.org/ref/4.0.0-rc-6/api/maven-api-plugin/plugin.html
see also apache/maven#13253

key difference is not only the new fields in Maven 4 plugin descriptor, but renamings:

• requiresDependencyResolution to dependencyResolution
• require* to new names
  see https://github.com/apache/maven/blob/master/api/maven-api-plugin/src/main/mdo/plugin.mdo#L211

[slawekjaranowski]

this acts also dropping maven-script and old-Maven 2-style javadoc annotations

so it will be a braking change

[slawekjaranowski]

I have checked plugin descriptor generated on a few plugins 3.x - build used plugin-tools 3.9.16 and 4.0.0-beta-3
looks the same

[slawekjaranowski]

We can try here it will be one less branch to maintain

[slawekjaranowski]

Of course we need check commits to cherry-pick, one I remember:

• Add validator for component requirements in generated plugin descriptor #1145

[gnodet-bot]

Three documentation issues in this version-switch PR.

1. Duplicate "Maven 3 Plugin API" link — src/site/markdown/index.md now lists [Maven 3 Plugin API](/ref/current/maven-plugin-api/) twice in the See Also section. The second entry appends ", with its plugin descriptor" as trailing text but does not actually link to the descriptor — both bullets point to the same URL. Suggest replacing the second entry with - [Maven 3 Plugin Descriptor](/ref/current/maven-plugin-api/plugin.html) to match the pattern used for Maven 4 on the next line.

2. Misleading Maven 4 link label — maven-plugin-tools-annotations/src/site/markdown/index.md adds:

Maven 4 [META-INF/maven/plugin.xml plugin descriptor](/ref/4-LATEST/api/maven-api-core/apidocs/org/apache/maven/api/plugin/annotations/package-summary.html)

The link text says "plugin descriptor" but the URL resolves to the annotation javadocs (package-summary.html), not a plugin descriptor schema. The correct target is likely /ref/4-LATEST/api/maven-api-plugin/plugin.html — consistent with the link on src/site/markdown/index.md line 70.

3. Stale javadoc groups — pom.xml has report groups for "Javadoc Tags Extractor + Taglets", "Beanshell Support", and "Apache Ant Support" that reference packages from the now-dropped maven-script and maven-plugin-tools-java modules. These groups will produce empty sections in javadoc reports. Also, .asf.yaml still says "produce Maven Plugins in scripting languages" — the scripting reference is now obsolete after maven-script is removed.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Duplicate link. Both this line and line 66 link to /ref/current/maven-plugin-api/. The trailing ", with its plugin descriptor" text is not a hyperlink — it should be a separate link to the descriptor page:

Suggested change

	- [Maven 3 Plugin API](/ref/current/maven-plugin-api/), with its plugin descriptor
	- [Maven 3 Plugin Descriptor](/ref/current/maven-plugin-api/plugin.html)

[gnodet-bot]

Misleading link target. The link text says plugin descriptor but the URL points to the annotations javadocs (package-summary.html), not to a descriptor schema. Consistent with src/site/markdown/index.md, this should point to /ref/4-LATEST/api/maven-api-plugin/plugin.html:

Suggested change

	- Maven 4 [META-INF/maven/plugin.xml plugin descriptor](/ref/4-LATEST/api/maven-api-plugin/plugin.html)