Repository navigation
Conversation
Only remove aliases that still refer to the validator being replaced or removed. Updating a secondary country code must not erase sibling aliases or a validator now assigned directly to that country code. Add regressions and a Jira-linked changes entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IBANValidator.setValidatorcould remove unrelated country-code aliases when a secondary code was changed or removed. Only remove an alias if it still refers to the validator being replaced, preserving sibling aliases and direct registrations.Adds regressions for alias replacement and removal, plus a VALIDATOR-510 changes entry.
Jira: https://issues.apache.org/jira/browse/VALIDATOR-510
Validation
mvn— success on the final patch.IBANValidatorTest— 435 passing cases.AI assistance used (Kiro) for code and test drafting and independent patch review.