Repository navigation
Conversation
mihaibudiu
reviewed
Oct 14, 2026
| .ok(expected); | ||
| } | ||
|
|
||
| /** Test case for |
Contributor
There was a problem hiding this comment.
this is not the example given in the Jira issue, so it's a bit tricky to figure out that the issue is indeed fixed.
Did you check that the current test case fails on 1.26 for example?
Member
Author
There was a problem hiding this comment.
Thank you for the reminder.
I verified the failure on 1.26 directly, would error out with NPE:
Exception in thread "main" java.lang.NullPointerException: Cannot invoke
"org.apache.calcite.rel.rel2sql.SqlImplementor$Context.field(int)"
because "correlAliasContext" is null
at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.toSql(SqlImplementor.java:705)
at org.apache.calcite.rel.rel2sql.RelToSqlConverter.visit(RelToSqlConverter.java:338)
In addition, tests from Jira cannot be used directly: the test builds the plan programmatically rather than using the JIRA's SQL verbatim, because the standard sql-to-rel conversion never produces the plan shape that triggers this bug.
mihaibudiu
approved these changes
Oct 18, 2026
xuzifu666
force-pushed
the
calcite-4592
branch
from
October 19, 2026 13:19
6b891fe to
490d03e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-4592
This issue should had been fixed, so I only add test case to cover it.