Repository navigation
[Experimental] Move pinned pip in setupVirtualenv to 26.2.2 - #40847
jrmccluskey wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40847 +/- ##
===========================================
+ Coverage 0 79.91% +79.91%
===========================================
Files 0 493 +493
Lines 0 83479 +83479
===========================================
+ Hits 0 66710 +66710
- Misses 0 16769 +16769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
There was a problem hiding this comment.
📋 Review Summary
This PR updates the pinned pip version in BeamModulePlugin.groovy (setupVirtualenv) from 25.0.1 to 26.2.2 and bumps RECOMMENDED_MIN_PIP_VERSION in sdks/python/setup.py to 26.2.2 in response to the eMudhra / emSign root CA certificate removal in certifi / pip 26.2.2. The changes are clean, minimal, and all triggered pre-commit and post-commit Python dependency test suites are passing.
🔍 General Feedback
- The
pip==26.2.2pin inBeamModulePlugin.groovyandRECOMMENDED_MIN_PIP_VERSIONinsdks/python/setup.pyalign with the recent container requirements update in #40696. - Follow-up note:
sdks/python/tox.inistill pinspip==25.0.1in[testenv:py311-ml](line 97) and[testenv:py311-transformers-{441,457,latest}](line 369); consider updating those environments topip==26.2.2as well if the resolver hang frompip 25.1is no longer present.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Move the pinned pip to 26.2.2, the first version with the emSign root CA certificate removed (https://discuss.python.org/t/information-for-python-users-regarding-emudhra-emsign-ca-certificate-security-incident/109576). Also recommends 26.2.2 as the new minimum pip version when installing.
DO NOT MERGE