Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40484 +/- ##
=============================================
+ Coverage 56.16% 79.72% +23.55%
=============================================
Files 1124 487 -637
Lines 178336 82280 -96056
Branches 1489 0 -1489
=============================================
- Hits 100170 65601 -34569
+ Misses 75645 16679 -58966
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
839deb4 to
9bc2827
Compare
|
|
||
| # This is an example of a Beam YAML pipeline that reads from GCS Avro files | ||
| # and writes to Cloud Bigtable. This matches the Dataflow Template located | ||
| # here - https://cloud.google.com/dataflow/docs/guides/templates/provided/avro-to-cloud-bigtable |
There was a problem hiding this comment.
What is our goal in mirroring all of these across both places? Do we intend to keep them totally in sync?
There was a problem hiding this comment.
It looks like we've been doing this for a while, but this seems like an antipattern to me
There was a problem hiding this comment.
Or are we just saying that this has the same functionality as the Java version of this template?
Btw, is there a reason we're back to blueprint terminology? That may be what is confusing me (#39549 (comment))
There was a problem hiding this comment.
What is our goal in mirroring all of these across both places? Do we intend to keep them totally in sync?
These examples are pending usage examples that I wanted to wrap up soon. Will remove the link to not have coupled so tightly explicitly. Also, its not meant to duplicate all. Just the most popular ones.
It looks like we've been doing this for a while, but this seems like an antipattern to me
That link was incorrectly linked and will remove.
Or are we just saying that this has the same functionality as the Java version of this template?
Yes, but will remove the link to avoid the confusion.
Btw, is there a reason we're back to blueprint terminology? That may be what is confusing me (#39549 (comment))
Sorry, I started treating anything that is yaml pipeline (with .yaml) as a blueprint regardless of the user. Let me update that to avoid more confusion.
There was a problem hiding this comment.
Let me update blueprint to pipelines in the next PR please. Thanks
…_to_cloud_bigtable # Conflicts: # sdks/python/apache_beam/yaml/examples/testing/examples_test.py
Uh oh!
There was an error while loading. Please reload this page.