Repository navigation
fix(model): traverse descendants in depth-first order - #5100
Merged
lxfu1 merged 1 commit intoOct 15, 2026
Merged
Conversation
cangen185-sudo
marked this pull request as ready for review
October 15, 2026 01:28
cangen185-sudo
marked this pull request as draft
October 15, 2026 01:28
cangen185-sudo
marked this pull request as ready for review
October 15, 2026 01:43
lxfu1
approved these changes
Oct 15, 2026
lxfu1
pushed a commit
that referenced
this pull request
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Make the default
Cell.getDescendants()traversal visit each child's subtree before the next sibling. The current implementation appends every immediate child first, then appends their descendants, despite the API documenting depth-first order.For
parent -> [first, second],first -> [child, sibling], andchild -> [grandchild], the expected order is[first, child, grandchild, sibling, second].馃挕 Motivation and Context
Build the result separately and append one child together with its descendants. The explicit breadth-first and shallow branches are unchanged. Add regressions for the default order, BFS,
deep: false, leaf cells and unchanged parent/child relationships.This corrects the documented default ordering. Deep clone/subgraph consumers may observe the corrected list order; membership is unchanged. Existing PR #5039 concerns removal of orphan children and changes a different method.
馃З Types of changes
馃攳 Validation
vitest run __tests__/model __tests__/plugin/selection.spec.ts: 323 passed.tsc --noEmit --pretty falseandgit diff --check: passed.sans-serifusing@napi-rs/canvas. The original unspecified-font failure was a font-width assumption in the unchangedDom.breakTexttest (174.21px text versus a 200px wrap threshold). Arial measures it as 248.09px. No production source, test assertions or system font settings were changed for this environment control.Codex assisted with audit, reproduction, implementation and local validation. Ready for maintainer review.