Repository navigation
fix(common): preserve caller-owned array paths - #5099
Merged
lxfu1 merged 1 commit intoOct 15, 2026
Merged
Conversation
cangen185-sudo
marked this pull request as ready for review
October 15, 2026 01:28
cangen185-sudo
marked this pull request as draft
October 15, 2026 01:28
cangen185-sudo
marked this pull request as ready for review
October 15, 2026 01:43
lxfu1
approved these changes
Oct 15, 2026
lxfu1
pushed a commit
that referenced
this pull request
Oct 15, 2026
fix(common): preserve array paths in object helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃摑 Description
ObjectExt.getByPath()consumes a caller-provided array withshift(), andsetByPath()removes its last element withpop(). Reusing the same path can therefore returnundefinedor write to a different property.Store.getByPath()exposes the same read-side effect.Copy array paths before consuming them, matching
unsetByPath()and the existing Store write path. String paths and delimiter behavior are unchanged. Add regressions for repeated reads/writes, missing properties and the public Store API.馃挕 Motivation and Context
For
const path = ['attr', 'fill'], reading{ attr: { fill: 'red' } }twice should return'red'twice and leavepathintact. Before this change, the first read empties the array and the second returnsundefined.No matching existing PR was found for
getByPath/setByPathduring the scoped duplicate search.馃З Types of changes
馃攳 Validation
vitest run __tests__/common/object __tests__/model/store.spec.ts: 41 passed.tsc --noEmit --pretty falseandgit diff --check: passed.sans-serifusing@napi-rs/canvas. The original unspecified-font run had oneDom.breakTextassertion failure: this machine measured the string as 174.21px, below the test's 200px wrap threshold; Arial measures it as 248.09px. No production source, test assertions or system font settings were changed for this environment control.let ret; a clean repository-wide lint/full-suite run is not claimed.Codex assisted with audit, reproduction, implementation and local validation. Ready for maintainer review.