Skip to content

fix(tui): use cross-platform path splitting for local plugin names in status dialog - #33375

Closed
licat2023 wants to merge 3 commits into
anomalyco:devfrom
licat2023:plugin-display-name
Closed

licat2023 wants to merge 3 commits into
anomalyco:devfrom
licat2023:plugin-display-name

Conversation

@licat2023

@licat2023 licat2023 commented Jun 22, 2026 •

Copy link
Copy Markdown

Issue for this PR

Closes #33373
Closes #16559

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

On Windows, fileURLToPath() returns paths with \ separators,
but the Status dialog display logic in packages/tui/src/component/dialog-status.tsx
only splits on /. The entire path is kept as a single string, and
.split(".")[0] truncates at the .config dot, showing C:\Users\licat\
instead of the plugin directory name.

This PR adds .replace(/\\/g, "/") before the split call to normalize
Windows backslashes, so the path component extraction works on all platforms.

How did you verify your code works?

  • bun typecheck passes in packages/tui/
  • Manually tested on Windows: added a local plugin path to opencode.json,
    opened the Status dialog, confirmed the plugin name displays its directory
    basename instead of a truncated path
  • Unix paths (no backslashes) are unchanged — no regression

Screenshots / recordings

Before After
C:\Users\licat\ opencode-lazy-loader

Before:
修改前

After:
修改后

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Jun 22, 2026
@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Jun 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local plugin names display as truncated path on Windows in status dialog fix: Plugin paths displayed incorrectly on Windows

1 participant