Skip to content

fix(angular-devkit): correctly parse inline boolean values in CLI options #34201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 wants to merge 6 commits into from
Closed

fix(angular-devkit): correctly parse inline boolean values in CLI options #34201

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e20112b
fix(@angular-devkit/schematics-cli): correctly parse inline boolean v…
alan-agius4 Sep 29, 2026
c724c1d
fix(@angular-devkit/architect): correctly parse inline boolean values…
alan-agius4 Sep 29, 2026
88f871f
fixup! fix(@angular-devkit/schematics-cli): correctly parse inline bo…
alan-agius4 Sep 29, 2026
df69c8e
fixup! fix(@angular-devkit/architect): correctly parse inline boolean…
alan-agius4 Sep 29, 2026
60654a0
fixup! fix(@angular-devkit/schematics-cli): correctly parse inline bo…
alan-agius4 Sep 29, 2026
b62b419
fixup! fix(@angular-devkit/architect): correctly parse inline boolean…
alan-agius4 Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/angular_devkit/architect/bin/architect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,14 @@ function parseOptions(args: string[]): Options {
}
}

for (const [key, value] of Object.entries(values)) {
if (value === 'true') {
values[key] = true;
} else if (value === 'false') {
values[key] = false;
}
}

return {
positionals,
builderOptions,
Expand Down
8 changes: 8 additions & 0 deletions packages/angular_devkit/schematics_cli/bin/schematics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,14 @@ function parseOptions(args: string[]): Options {
}
}

for (const [key, value] of Object.entries(values)) {
Comment thread
alan-agius4 marked this conversation as resolved.
Outdated
if (value === 'true') {
values[key] = true;
} else if (value === 'false') {
values[key] = false;
}
}

return {
_: positionals,
schematicOptions,
Expand Down
27 changes: 27 additions & 0 deletions packages/angular_devkit/schematics_cli/test/schematics_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,33 @@ describe('schematics-cli binary', () => {
expect(res).toEqual(0);
});

it('handles boolean CLI options with explicit inline false values', async () => {
const args = ['blank', 'foo', '--dry-run', '--debug=false'];
const res = await main({ args, stdout, stderr });
const output = stripVTControlCharacters(stdout.read()?.toString() || '');
expect(output).not.toMatch(/Debug mode enabled/);
expect(output).toMatch(/Dry run enabled\./);
expect(res).toEqual(0);
});

it('does not display help when --help=false is passed', async () => {
const args = ['blank', 'foo', '--dry-run', '--help=false'];
const res = await main({ args, stdout, stderr });
const output = stripVTControlCharacters(stdout.read()?.toString() || '');
expect(output).not.toMatch(/schematics \[collection-name:\]schematic-name/);
expect(output).toMatch(/Dry run enabled\./);
expect(res).toEqual(0);
});

it('does not list schematics when --list-schematics=false is passed', async () => {
const args = ['blank', 'foo', '--dry-run', '--list-schematics=false'];
const res = await main({ args, stdout, stderr });
const output = stripVTControlCharacters(stdout.read()?.toString() || '');
expect(output).not.toMatch(/blank/);
expect(output).toMatch(/Dry run enabled\./);
expect(res).toEqual(0);
});

it('error when no name is provided', async () => {
const args = ['blank'];
const res = await main({ args, stdout, stderr });
Expand Down
Loading