Repository navigation
ateapi: Cover Golden snapshot preferred fidelity - #2821
Closed
Luomu (cloudonly) wants to merge 1 commit into
Closed
Luomu (cloudonly) wants to merge 1 commit into
Luomu (cloudonly) wants to merge 1 commit into
Conversation
Cover the default and all supported fidelities through Golden creation, publication, and inheritance so forced MEMORY requests or snapshot metadata cannot regress silently.
Luomu (cloudonly)
force-pushed
the
test/golden-preferred-fidelity
branch
from
October 18, 2026 05:08
8a63fd2 to
815ff43
Compare
Luomu (cloudonly)
marked this pull request as ready for review
October 18, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise Golden creation with the default, MEMORY, VOLUMES, and ROOTFS fidelities. Check the outgoing Checkpoint request, published Golden tag, and inherited actor snapshot so forcing MEMORY in either the request or snapshot metadata is caught.
Closes #2383.
Validation of the rebased source on Linux/amd64 with Go 1.27.2 as a non-root user with
CI=true:go test -race -count=1 ./...passed on the first run, with 167 test packages passing.TestGoldenSnapshotPreferredFidelityand all four subtests ran and passed against PostgreSQL and envtest.hack/verify-all.shpassed all 16 checks on retry, with a clean source tree. The initial lint run reached its default 5-minute timeout while compiling cold dependencies. Its configuration and timeout were unchanged.Earlier pre-rebase validation encountered ENOENT in the unchanged
internal/credbundle/TestLoaderConcurrentHandshakes; isolated repetition reproduced it 3 out of 30 times. It did not recur in the full run on the rebased source.Runtime cluster E2E was not run.
AI assistance: Codex helped write and validate the regression test.