This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
WIN: UI shakes and flickers a lot when resizing Brackets window by dragging #4841
Description
Description:
On Windows, the UI shakes & flickers a lot when you resize the Brackets window by dragging the top edge or the left edge of the Brackets window. The problem is much less noticeable when dragging the bottom edge or right edge. It's really noticeable if you have multiple inline color editors open. I tried making a Jing screen capture video, but the jiggle isn't picked up in the video. Maybe related to #1741?
keywords: jumpy, choppy, jiggles, jumps
Repro using Brackets Sprint 29 on Win 7. UTR on Mac 10.8.
Repro steps:
- Open a css file and invoke inline color editor in multiple places. Also happens with an html file.
- Resize the Brackets window by dragging the top edge or the left edge of the Brackets window.
Actual results:
UI shakes and flickers a lot.
Expected results:
UI doesn't shake and flicker a lot.
Workaround:
Deal with cosmetic issue.
Activity
gruehle commentedon Aug 26, 2013
Reviewed. Medium priority to @JeffryBooher
rajeshsegu commentedon Aug 30, 2013
We could throttle the call of the resize handler once every 100ms. ( http://underscorejs.org/#throttle ). Today in a given second its fired close to 100+ times which is waste of DOM cycles. Meanwhile, the flicker is also related to CodeMirror resizing their code very often, we can sync them both at once is 200ms, which I think is reasonable.
redmunds commentedon Nov 16, 2013
@dalcala I remember this being really bad. I'm not sure what changed, but this seems way better to me now on Win7. Are you still seeing the problem?
peterflynn commentedon Mar 18, 2014
Removing top/left from title since you can see this with any resize (and same with #5258)
[-]Win: UI shakes and flickers a lot when resizing Brackets window by dragging from top edge or left edge[/-][+]Win: UI shakes and flickers a lot when resizing Brackets window by dragging[/+]JeffryBooher commentedon May 27, 2014
Adding CEF/TRACKING -- although this could be solved in shell or more efficient DOM
[-]Win: UI shakes and flickers a lot when resizing Brackets window by dragging[/-][+][CEF 2171] WIN: UI shakes and flickers a lot when resizing Brackets window by dragging[/+]JeffryBooher commentedon Nov 18, 2014
WOW. This got incredibly worse with CEF 2171
JeffryBooher commentedon Nov 21, 2014
https://code.google.com/p/chromiumembedded/issues/detail?id=1448
peterflynn commentedon Dec 3, 2014
@JeffryBooher I'm not seeing a regression here with CEF 2171. On Win 7, it actually seems to respond to resizing more smoothly and quickly than CEF 1547.
RaymondLim commentedon Dec 3, 2014
@peterflynn In CEF 2171 I can see the flickering in the area covered by the border, title bar and the menu bar, but not in the side bar or the editor area.
peterflynn commentedon Dec 4, 2014
I busted out the trusty high-speed camera for a quick test.
It seems like these are both things we could fix on our end:
However, I'll reiterate that to my eyes, the jitter is only a tiny bit worse than 1547 and seems reasonable enough to ship with.
peterflynn commentedon Dec 4, 2014
I also checked cefclient 2171 just for kicks. The CEF content is way less responsive to resizing overall (I'm guessing because cefclient is always a debug build?), but it doesn't show either of the problems above. But I'm not sure if it's doing anything specific to repaint the border better, or if that's just something you get for free if you're using the OS-standard Aero border instead of painting your own.
JeffryBooher commentedon Dec 5, 2014
@peterflynn the installed build seems to paint much faster than my "debug" build so I'm going to lower-the priority on this one for now and remove the milestone.
[-][CEF 2171] WIN: UI shakes and flickers a lot when resizing Brackets window by dragging[/-][+]WIN: UI shakes and flickers a lot when resizing Brackets window by dragging[/+]