Repository navigation
Support get manifest from local #463
Description
Description:
We ran into a rate limit issue while running our GitHub Enterprise Server instance.
There are several topics discussed below, but they are not suitable for us.
#219, #427, #316
The rate limit problem seems to be caused by importing the manifest file located on github.com.
Wouldn't the problem go away if the action import a local manifest file instead?
I suggest using a local file instead of calling the api to github.com if the hosted runner has a specific environment variable (eg, SETUP_PYTHON_MANIFEST_FILE_LOCATION).
https://github.com/actions/setup-python/blob/main/src/install-python.ts#L19
+ # pseudo code
+ if (SETUP_PYTHON_MANIFEST_FILE_LOCATION is set) {
+ const manifest: tc.IToolRelease[] = getManifestFromLocal(
+ ...
+ } else {
const manifest: tc.IToolRelease[] = await tc.getManifestFromRepo(Justification:
Justification or a use case for your proposal.
Are you willing to submit a PR?
Activity
IvanZosimov commentedon Jul 15, 2022
Hi, @retzero 👋 ! Thank you for this feature request! Unfortunately we aren't planning to implement this feature, but probably I can help you with the issue itself. What is your current rate limit? (check this info about getting your rate limit)
retzero commentedon Jul 20, 2022
@IvanZosimov
Thank you for the feedback. I'm looking for a more efficient way to solve the rate limit problem. This is our situation.
IvanZosimov commentedon Jul 21, 2022
Hi, @retzero, thanks for clarifying your case. Unfortunately, I think the best way to solve your problem is to fork action as was suggested here and apply the changes you need.
brcrista commentedon Aug 5, 2022
Duplicate of #229
brcrista commentedon Aug 5, 2022
Definitely don't put it in your source code. You would store it as a secret in your repo.