[t-hamano]

Problem

This PR fixes an issue where the action incorrectly detects a "first interaction" and greets contributors who are not actually first-time contributors.

This conditional statement was modified by #311, which appears to be unintentional.

Before:

let firstContribution = false;
if (isIssue) {
    firstContribution = yield isFirstIssue(client, issue.owner, issue.repo, sender, issue.number);
}
else {
    firstContribution = yield isFirstPull(client, issue.owner, issue.repo, sender, issue.number);
}
if (!firstContribution) {
    console.log('Not the users first contribution');
    return;
}

https://github.com/actions/first-interaction/pull/311/changes#diff-7934bf411fea192ad8cd69e0a12911648a2842cb0f2409a8fb67b41b7069d757L62-L67

After:

if (!(await isFirstIssue(octokit)) && !(await isFirstPullRequest(octokit)))
    return core.info('Skipping...Not First Contribution')

https://github.com/actions/first-interaction/pull/311/changes#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3dR46

This logic change will cause isFirstIssue to always be true if the issue feature is disabled on the repository, consequently adding a message to contributors who have already submitted a PR.

Approach

Restore the original behavior: evaluate only the check matching the event type. As a result, both the first issue and the first pull request are considered first contributions. This is the same specification as before the action was converted from a container action.

[Copilot]

Pull request overview

This PR restores the original “first interaction” semantics by checking only the contribution type that matches the triggering event (issue vs pull request), preventing repeat contributors from being incorrectly greeted when only one feature (issues/PRs) is enabled.

Changes:

• Update first-contribution detection to evaluate only isFirstIssue for issue events and only isFirstPullRequest for PR events.
• Regenerate dist/index.js to reflect the source change.
• Expand/adjust unit tests to cover event-specific first-contribution scenarios.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/main.ts	Restores event-specific first-interaction detection logic (issue vs PR).
dist/index.js	Updates the built artifact to match src/ behavior changes.
__tests__/main.test.ts	Adds/updates tests for event-specific skipping behavior (but needs tightening to catch regressions).

Comments suppressed due to low confidence (1)

tests/main.test.ts:96

• This test now describes “prior issues and PRs”, but run() only evaluates the first-contribution check that matches the event type (issue vs PR). Because the default test context is a PR event, the current setup (mocking two paginate calls) can still pass even if a regression reintroduces calling both checks. Rename the test to match the PR-only behavior and assert the correct API call/count.

    it('Skips a message if the sender has prior issues and PRs', async () => {
      mocktokit.paginate
        // Issues
        .mockResolvedValueOnce([
          {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.

[desrosj]

Fixes #369.

@ncalteen 👋 Tagging as the person who has maintained this repository most recently based on commit activity. Would it be possible to get a review for this, or assigned to someone who can? We're using it in the https://github.com/WordPress/wordpress-develop/ repository (which does not use issues) and it is causing a good amount of noise. Thanks in advance!

[michen00]

Cross-linking #402, which rewrites the same lines. The archaeology tracing this to #311 is the clearest statement of the problem I've seen.

One difference worth flagging before either merges: #410 leaves isFirstPullRequest as-is, and it never filters by author.

return (
  // Filter out any PRs that are newer than the current one.
  pulls.filter((pull) => pull.number < github.context.issue.number)
    .length === 0
)

pulls.list is called with only owner, repo and state: 'all' — there is no creator parameter for pulls — so this returns true only when the incoming PR is the lowest-numbered PR in the repo. On main that is masked whenever the sender has no prior issues, because !(await isFirstIssue(...)) && !(await isFirstPullRequest(...)) short-circuits before reaching it. Once PR events route solely through this helper it is evaluated on every PR, and after a repo's first-ever PR nothing is ever greeted again. That is the mirror image of #369 — over-greeting becomes never-greeting — and quieter to notice.

#311 removed two things at once: the per-type branching and the author filter. The lib/main.js excerpt in the description shows the first; the second is in the same diff, in the removed lines of src/main.ts:

// No way to filter pulls by creator
async function isFirstPull(…) {
  …
  for (const pull of pulls) {
    const login = pull.user?.login;
    if (login === sender && pull.number < curPullNumber) {
      return false;
    }
  }

Restoring only the branching leaves the second half in place, which turns the bug inside out instead of fixing it.

The tests won't catch it, because no PR mock carries a user field:

mocktokit.paginate.mockResolvedValueOnce([
  {
    number: 10
  },
  {
    number: 5
  }
])

Returns false if older PRs are present passes whether or not those PRs belong to the sender.

#402 has taken the stricter reading after review feedback there — greet only on a contributor's first interaction of any kind — so the two PRs have diverged on semantics. The missing author filter is orthogonal to that argument though: whichever branching wins, isFirstPullRequest needs the filter. The two branches do conflict (src/main.ts, the tests and dist/), so it's worth settling the semantics question first and then taking whichever branch carries the filter.