Skip to content

Vue TodoMVC source maps include full path of author's machine #385

Open

Description

@lpardosixtosMs

The source maps for Vue TodoMVC are using the full path instead of the relative path, causing fake file changes every time a new person builds it. E.g:

"\n\nimport exportComponent from \"/Users/thorstenk/Desktop/FlashDesignory/Speedometer/resources/todomvc/architecture-examples/vue/node_modules/vue-loader/dist/exportHelper.js\"\n

to

"\n\nimport exportComponent from \"/home/issackjohn/issack/Speedometer/resources/todomvc/architecture-examples/vue/node_modules/vue-loader/dist/exportHelper.js\"\n

in #376.

Activity

  1. rniwa commented on Feb 29, 2024

    @rniwa
    Member

    Oh, can we fix this before 3.0 release?

  2. julienw commented on Mar 4, 2024

    @julienw
    Contributor

    One can see the webpack config used by vue like this:

    ./node_modules/.bin/vue-cli-service inspect --mode production 2>&1| less
    

    Here we clearly see that the absolute directory is used everywhere. I'm not sure which of these impacts the source map generation.
    Clearly in my other non-vue webpack-based project this isn't happening.

  3. reopened this on Mar 4, 2024
  4. rniwa commented on Mar 4, 2024

    @rniwa
    Member

    Removing v3-blocker keyword since this doesn't need to block the release of Speedometer 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    trivial changeA change that doesn't affect benchmark results

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions