Repository navigation
feat: remove all mentions of Notion - #286
angelayzheng wants to merge 3 commits into
Conversation
qiuethan
left a comment
There was a problem hiding this comment.
Reviewed the complete removal change and approved the intentional retirement cleanup.
The follow-up documentation commit makes documentation-system 009 and team-tracking 011 explicit exceptions to data rollback: downgrade restores registry entries only. Both CONTRIBUTING guides now link to that shared rule; other migrations retain the normal reversibility requirement. Backup/recovery limitations remain documented.
Verification passed against disposable PostgreSQL 16 with pgvector: populated upgrade/downgrade/re-upgrade checks preserved documents, tags, grants, content, chunks and unrelated directory records, while removing only the retired identities. PostgreSQL-backed API checks confirmed registry removal and ordinary web handling for retired URLs. Both complete affected Python suites, the full bot suite and relevant lint/format checks passed; Python src/contracts imports were pinned and their paths verified. External providers were faked.
No actionable findings remain. The latest commit only changes migration guidance; the verified migration implementations are unchanged.
All CI checks passed on the reviewed head 4f43f30.
qiuethan
left a comment
There was a problem hiding this comment.
Re-reviewed 4f43f30. No additional standalone findings; the documented registry-only rollback behavior remains intentional.
Focused offline migration, provider, in-memory adapter, URL normalization, and backfill tests passed against isolated snapshots with source imports verified. Current CI checks are green. Postgres suites were not rerun in this review.
Merge coordination: this PR and #282 both introduce documentation-system revision 009. If this PR merges first, #282 must rebase, renumber its migration to the next sequential revision, update down_revision, and verify upgrade/downgrade/upgrade before merging.
What this changes
Removes Notion references from documentation, code comments, fixtures, and tests while preserving historical migrations. New migrations reassign existing Notion documents to
web, delete Notion identity rows, and remove the source and provider registry entries; new URLs use ordinary web-link handling.Why
UTMIST no longer uses Notion for internal documentation.
Closes #275.
Zone
root·discord-bot·services/connectors·services/documentation-system·services/team-trackingThis deliberately spans zones because removing the integration requires coordinated registry migrations, fixture updates, and documentation cleanup across the platform.
contracts/types.pyandsrc/backfill.pyupdate outdated examples.AGENTS.mdrecords the new migration heads and narrowly permits registry-only rollback for documentation-system009and team-tracking011. Both services'docs/CONTRIBUTING.mdlink to that shared rule so their migration instructions agree with the intentional retirement cleanup.How to verify
Against disposable local PostgreSQL databases:
The final search should return only the unchanged historical seed migrations.
Regression tests cover document preservation, URL fallback to
web, deletion of only the retired identity rows, and restoration of registry entries on downgrade.Local review verification passed both complete affected Python suites, including PostgreSQL integration and migration tests, the full bot suite, and the relevant lint/format checks. Additional checks against disposable PostgreSQL 16 with pgvector exercised populated upgrade/downgrade/re-upgrade paths: active and inactive documents, tags, grants, content and chunks survive; only retired identity rows are removed, while other identities, people, memberships and groups survive. Python src/contracts imports were pinned to the isolated review worktree and their file paths verified. Provider calls used fakes.
Checklist
stagingand targetingstaging.uv run ruff check .anduv run ruff format --check .clean.docs/CONTRIBUTING.mdguidance, including the explicit retirement-cleanup rollback exceptions.Deployment notes
009and team-tracking revision011. PostgreSQL upgrade/downgrade/re-upgrade checks passed locally on disposable databases with existing rows; no deployed database was changed during review./sourcesand/providers. Existing documents remain available aswebdocuments; former Notion identity mappings are removed.Anything you're unsure about
The retirement cleanup is intentionally permanent. The explicit exceptions in
AGENTS.mdmatch the migration code and deployment notes; all other migrations retain the normal reversibility requirement. Populated PostgreSQL checks confirmed the documented behavior.