Skip to content

Deprecate shadow stack #74

Open
Open
Deprecate shadow stack#74
Labels
good first issueGood for newcomershelp wantedExtra attention is needed

Description

@playXE
playXE
opened on Jul 6, 2021

Since GC now can find pointers to the heap on the stack shadow stack is almost useless now.

Depends on #73 so we can find JS values on the stack.

Activity

  1. playXE commented on Jul 10, 2021

    @playXE
    playXE
    on Jul 10, 2021
    CollaboratorAuthor

    We should slowly start remove uses of letroot!. Rules for removing it are simple:

    • if letroot is used to root JsValue then remove its usage
    • if letroot is used to root GcPointer or WeakRef or any struct that is allocated on stack and contains GC pointer remove its usage
    • if letroot is used to root Vec,Box or other non GC allocated type that might point to GC objects do not remove letroot
  2. playXE
    added
    good first issueGood for newcomers
    help wantedExtra attention is needed
    on Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions