Repository navigation
Conversation
- Send Wi-Fi provisioning credentials with SET BWIFI instead of quoted SET WIFI. - Encode UI-provided SSID and password as UTF-8 base64 in desktop and Android serial handlers. - Preserve empty-password provisioning by sending an explicit empty password argument. - Avoid parser issues with special characters commonly found in ISP-provided router credentials.
qus20000
requested review from
ButterscotchV,
Erimelowo and
loucass003
as code owners
September 20, 2026 17:40
Member
|
Please implement it to server rewrite. see #1880 |
Author
Hello, Thanks for the clarification. I wasn’t aware that the server rewrite was already in progress, and I’m sorry I missed that. I’ll review the server-rewrite structure, rework the changes if needed, and then submit a PR against the rewrite branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes serial Wi-Fi provisioning to send credentials with
SET BWIFIinstead of quotedSET WIFI.The SSID and password entered in the UI are still handled as normal text in the app, but are encoded as UTF-8 base64 immediately before being written to the tracker serial port.
Why
The tracker firmware already supports
SET BWIFIfor base64-encoded Wi-Fi credentials. This avoids command parser ambiguity when SSIDs or passwords contain spaces, quotes, non-ASCII characters, or punctuation.This is a real setup issue for users in Korea: ISP-provided routers from the three major carriers commonly ship with SSIDs and/or default passwords containing special characters, for example
+or@. Sending those values through the quotedSET WIFI "<ssid>" "<password>"command can fail during provisioning even though the same credentials are valid.Using
SET BWIFImakes the serial payload command-safe while keeping the UI behavior unchanged.Compatibility
SET BWIFIis supported by the stock SlimeVR Tracker ESP firmware and was added as part of the firmware's base64 Wi-Fi credential command support.Testing
git diff --check.\gradlew.bat :server:desktop:compileKotlin --no-daemon