Skip to content

Multiple cookies are not received by default/httplib and requests client #192

Open

Description

@wosc

If the server sends multiple Set-Cookie headers, both the default and the requests client conflate those into one header-line, comma-separating the values -- which cookiejar cannot parse. Luckily, the urllib3 client keeps the headers as-is, so that it works in this case.

Activity

  1. gawel commented on May 9, 2018

    @gawel
    Member

    I guess you're referring to WSGIProxy2 ? That's weird since requests use urllib3

  2. wosc commented on May 10, 2018

    @wosc
    ContributorAuthor

    Hrm, it's a mix-up between wsgiproxy and webtest, I think. For which actually requests is the perfect example, as they behave really sneaky regarding cookies: for their own cookie-handling they send off the urllib3 Response object (which has individual set-cookie headers) to the cookiejar, before wrapping it in their own requests Response object (which then conflates them) -- which doesn't work for webtest, since that operates on the completed Response object of the client: https://github.com/Pylons/webtest/blob/master/webtest/app.py#L659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions