Repository navigation
WIP: test against Python 3.8 - #525
Conversation
add Python 3.7 and 3.8 on Appveyor
41d7cb1 to
1300ce3
Compare
|
Python 3.8 is passing! The |
|
I think we should just remove DISTUTILS_USE_SDK and all will be well |
This was needed for Python 3.4, but not 3.5
|
Actually the tests for 3.8 were not run on Travis due to some pytest-related import error causing 0 tests to be found: https://travis-ci.org/PyWavelets/pywt/jobs/599345508#L917-L954 |
|
I don't understand the import error on Travis, particularly the following section In my local copy of Python 3.8 there is no The test suite ran normally on Python 3.8 when I tried it locally on a 64-bit linux machine. |
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
========================================
Coverage ? 63.5%
========================================
Files ? 23
Lines ? 3891
Branches ? 467
========================================
Hits ? 2471
Misses ? 1351
Partials ? 69Continue to review full report at Codecov.
|
|
Marking this as WIP for now. I don't think it is useful to merge as is since the tests on 3.8 are not currently being run. They did get run over at MacPython/pywavelets-wheels#9 and are passing there, so I think we can work on this again after the 1.1 release. |
|
Ah I missed this one - should we merged as is? |
|
Okay, I think this looks good now. Probably want to squash the commits on merge to get rid of some of the noise (or I can do it manually if you prefer) |
This PR is an attempt to test against Python 3.8.