Repository navigation
Browser tabs: tidy page text for data: pages; docs on pop-ups after a click - #27
Merged
Merged
Conversation
…an open a pop-up shortly after a click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #26. This commit was pushed to
agents-team/browser-tabsminutes after #26 merged, so it never made it intomain.Two findings from a hands-on test of the tabs:
data:pages:new_tabandnavigategave an empty address and showed thedata:URL as the title, for example "Loaded (title: data:text/html,…)". The tab list also printed the wholedata:URL twice. Now one helper,BrowserPanel.Page, writes both messages. It gives the real address, throughlocation.href, since WebView2 reports noSourcefor adata:page. It leaves out a title that only repeats the address, and cuts addresses at 80 characters.clicktool's clicks count. README, PRIVACY.md and CLAUDE.md said popups open "only when user-initiated" without saying this. They now do. The behavior is unchanged: addresses outside the allowed list are still refused, and there are still at most 20 tabs.Checks:
dotnet build -c Releasehas 0 warnings,dotnet test -c Releasepasses 445/445 (4 newPagetests), and--smokeexits 0.🤖 Generated with Claude Code