Skip to content

[codex] fix util stripVTControlCharacters unicode literals - #4189

Merged
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-util-strip-vt-unicode
Jun 3, 2026
Merged

proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-util-strip-vt-unicode

Conversation

@andrewtdiz

Copy link
Copy Markdown
Contributor

Summary

  • preserve UTF-8 characters while the parser normalizes Unicode identifier escapes outside strings
  • strip VT control sequences over JS string bytes so multibyte payload text is copied through unchanged
  • keep stripVTControlCharacters() string argument handling SSO-aware via the shared string byte-view helper

Validation

  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh
  • cargo test -p perry-parser normalize_
  • cargo check -p perry-parser -p perry-runtime -p perry
  • ./run_parity_tests.sh --suite node-suite --module util --filter strip-vt-control-characters/non-ascii
  • ./run_parity_tests.sh --suite node-suite --module util --filter strip-vt-control-characters
  • ./run_parity_tests.sh --suite node-suite --module buffer --filter from/string-encodings
  • cargo build --release -p perry

Refs #2514

@proggeramlug
proggeramlug marked this pull request as ready for review June 3, 2026 03:12
@proggeramlug
proggeramlug force-pushed the codex/node-compat-util-strip-vt-unicode branch from 5993f28 to b13b00a Compare June 3, 2026 03:20
@proggeramlug
proggeramlug merged commit 70c6956 into PerryTS:main Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants