Repository navigation
fix(util): mirror toUSVString into sys alias — restores main (#2514) - #3436
Merged
Merged
Conversation
Restores main: #3421 added util.toUSVString without the matching sys mirror, breaking the sys_alias_mirrors_util_manifest test.
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
mainto green.#3421 added
util.toUSVStringbut not the matchingsysalias entry, sosys_alias_mirrors_util_manifest(which assertsnode:sysmirrorsnode:util's manifest surface) fails on main —syshas one fewer entry thanutil.This adds
method("sys", "toUSVString", false, None)alongside the othersysutil-mirror entries.cargo test -p perry-api-manifest --lib sys_alias→ passes (was failing on main).cargo fmt --all -- --checkclean; api docs unchanged (sys alias isn't emitted to the .d.ts surface).