Skip to content

Give the retention sweep tests a larger wait budget on slow CI runners - #5985

Open
ramonsmits wants to merge 1 commit into
masterfrom
retention-sweep-wait-timeout
Open

ramonsmits wants to merge 1 commit into
masterfrom
retention-sweep-wait-timeout

Conversation

@ramonsmits

Copy link
Copy Markdown
Member

RetentionSweepTests.A_sweep_cancelled_between_batches_is_recorded_as_cancelled fails now and then on the Linux SQL Server job. The test waits 10 seconds for the manual sweep to stop. In the failing runs the sweep's first batch delete alone took over 10 seconds, so the wait expired while the sweep was still running.

The slow delete is most likely contention on the shared full-text catalog: every parallel test schema puts its FailedMessages full-text index in the same catalog, and a delete on that table waits for other tests' index DDL. That is a separate change.

@rbev rbev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's probably contention on full text that causes this, and why it's hard to see when you have speedy SSD disks locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants