Repository navigation
Give the retention sweep tests a larger wait budget on slow CI runners - #5985
Open
ramonsmits wants to merge 1 commit into
Open
ramonsmits wants to merge 1 commit into
ramonsmits wants to merge 1 commit into
Conversation
rbev
approved these changes
Oct 12, 2026
rbev
left a comment
Contributor
There was a problem hiding this comment.
I agree that it's probably contention on full text that causes this, and why it's hard to see when you have speedy SSD disks locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetentionSweepTests.A_sweep_cancelled_between_batches_is_recorded_as_cancelledfails now and then on the Linux SQL Server job. The test waits 10 seconds for the manual sweep to stop. In the failing runs the sweep's first batch delete alone took over 10 seconds, so the wait expired while the sweep was still running.WaitForManualSweepToFinishnow waits up to 60 seconds. The wait returns as soon as the sweep stops, so the larger budget only costs time when the sweep is stuck.The slow delete is most likely contention on the shared full-text catalog: every parallel test schema puts its
FailedMessagesfull-text index in the same catalog, and a delete on that table waits for other tests' index DDL. That is a separate change.