Repository navigation
Conversation
The firmware now ships the PTZ controls only where gpio-motors or majestic-af is built in, and the KC110 drives its steppers through its own gpio-motors shim instead, so the package selects the option itself.
widgetii
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
October 13, 2026 10:26
Contributor
|
/review |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn these tips off under Display > Comment parts |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenIPC/firmware#2583 makes the WebUI's PTZ controls a build option,
BR2_PACKAGE_MAJESTIC_WEBUI_PTZ. It defaults on only whereBR2_PACKAGE_GPIO_MOTORSorBR2_PACKAGE_MAJESTIC_AFis enabled; images without a driver lose the pad's code and get an emptyp/motor.cgi.The TP-Link Kasa KC110 drives its steppers through this package's own
/usr/bin/gpio-motorsshim instead of the gpio-motors package, so that default can't see it. The package now selects the option, guarded byif BR2_PACKAGE_MAJESTIC_WEBUI.Ordering
This PR is safe on its own. Until firmware#2583 lands the symbol is undefined, and buildroot's Kconfig ignores a
selectof an undefined symbol silently: no error, no warning, exit 0. I checked that with theconftool from a buildroot 2024.02.10 build. The line does nothing until the option exists, and then keeps the KC110's PTZ controls.Verification
yfor a majestic-af board (hi3516ev300_lite) and a gpio-motors board (gk7205v500_lite), and stays unset for hi3516av300_lite. The select is what covers the KC110.