Repository navigation
Bootstrapping fails on OpenMPTCProuter v0.59 (a build of OpenWRT) #130
Copy link
Copy link
Open
Description
To run the bootstrap I needed to fake groups and whoami executables. The related (sub-) issue: #137
Then it failed due to missing nawk:
root@OpenMPTCProuter:~/debug/src/github.com/NetBSD/pkgsrc.git# bootstrap/bootstrap
...
===> running: /bin/sh /root/debug/src/github.com/NetBSD/pkgsrc.git/work/bin/install-sh -c -o root -g root -m 755 /root/debug/src/github.com/NetBSD/pkgsrc.git/work/pkg_install/add/pkg_add /root/debug/src/github.
com/NetBSD/pkgsrc.git/work/sbin/pkg_add
===> running: /bin/sh /root/debug/src/github.com/NetBSD/pkgsrc.git/work/bin/install-sh -c -o root -g root -m 755 /root/debug/src/github.com/NetBSD/pkgsrc.git/work/pkg_install/admin/pkg_admin /root/debug/src/git
hub.com/NetBSD/pkgsrc.git/work/sbin/pkg_admin
===> running: /bin/sh /root/debug/src/github.com/NetBSD/pkgsrc.git/work/bin/install-sh -c -o root -g root -m 755 /root/debug/src/github.com/NetBSD/pkgsrc.git/work/pkg_install/create/pkg_create /root/debug/src/g
ithub.com/NetBSD/pkgsrc.git/work/sbin/pkg_create
===> running: /bin/sh /root/debug/src/github.com/NetBSD/pkgsrc.git/work/bin/install-sh -c -o root -g root -m 755 /root/debug/src/github.com/NetBSD/pkgsrc.git/work/pkg_install/info/pkg_info /root/debug/src/githu
b.com/NetBSD/pkgsrc.git/work/sbin/pkg_info
sh: -f: not found
bmake[1]: "/root/debug/src/github.com/NetBSD/pkgsrc.git/lang/gcc6/options.mk" line 77: warning: "echo 6.5.0 | -f ../../mk/scripts/larger_symbol_version.awk" returned non-zero status
sh: -f: not found
bmake[1]: "/root/debug/src/github.com/NetBSD/pkgsrc.git/lang/gcc6/options.mk" line 77: warning: "echo 6.5.0 | -f ../../mk/scripts/larger_symbol_version.awk" returned non-zero status
sh: {print $3; exit}: not found
bmake[1]: "/root/debug/src/github.com/NetBSD/pkgsrc.git/mk/tools/gmake.mk" line 43: warning: "/usr/bin/make --version | '{print $3; exit}'" returned non-zero status
===> running: (cd /root/debug/src/github.com/NetBSD/pkgsrc.git/pkgtools/cwrappers && /root/debug/src/github.com/NetBSD/pkgsrc.git/work/bin/bmake MAKE_JOBS=1 PKG_COMPRESSION=none PKGSRC_KEEP_BIN_PKGS=no MAKECON
F=/root/debug/src/github.com/NetBSD/pkgsrc.git/work/mk.conf install)
sh: -f: not found
bmake[1]: "/root/debug/src/github.com/NetBSD/pkgsrc.git/lang/gcc6/options.mk" line 77: warning: "echo 6.5.0 | -f ../../mk/scripts/larger_symbol_version.awk" returned non-zero status
sh: -f: not found
bmake[1]: "/root/debug/src/github.com/NetBSD/pkgsrc.git/lang/gcc6/options.mk" line 77: warning: "echo 6.5.0 | -f ../../mk/scripts/larger_symbol_version.awk" returned non-zero status
sh: {print $3; exit}: not found
bmake[1]: "/root/debug/src/github.com/NetBSD/pkgsrc.git/mk/tools/gmake.mk" line 43: warning: "/usr/bin/make --version | '{print $3; exit}'" returned non-zero status
/root/debug/src/github.com/NetBSD/pkgsrc.git/mk/pkgformat/pkg/list-dependencies: line 47: /usr/pkg/bin/nawk: not found
===> Installing dependencies for cwrappers-20220403
/root/debug/src/github.com/NetBSD/pkgsrc.git/mk/pkgformat/pkg/list-dependencies: line 47: /usr/pkg/bin/nawk: not found
*** Error code 1
Stop.
bmake: stopped in /root/debug/src/github.com/NetBSD/pkgsrc.git/pkgtools/cwrappers
===> exited with status 1
aborted.
The OS:
root@OpenMPTCProuter:~/debug/src/github.com/NetBSD/pkgsrc.git# uname -a
Linux OpenMPTCProuter 5.4.194 #0 SMP Tue May 17 22:11:28 2022 x86_64 GNU/Linux
root@OpenMPTCProuter:~/debug/src/github.com/NetBSD/pkgsrc.git# cat /etc/os-release
NAME="openmptcprouter"
VERSION="v0.59.1-5.4"
ID="openmptcprouter"
ID_LIKE="lede openwrt"
PRETTY_NAME="openmptcprouter v0.59.1-5.4"
VERSION_ID="v0.59.1-5.4"
HOME_URL="https://openwrt.org/"
BUG_URL="https://bugs.openwrt.org/"
SUPPORT_URL="https://forum.openwrt.org/"
BUILD_ID="r0+16594-ce92de8c8c"
OPENWRT_BOARD="x86/64"
OPENWRT_ARCH="x86_64"
OPENWRT_TAINTS="busybox override"
OPENWRT_DEVICE_MANUFACTURER="OpenWrt"
OPENWRT_DEVICE_MANUFACTURER_URL="https://openwrt.org/"
OPENWRT_DEVICE_PRODUCT="Generic"
OPENWRT_DEVICE_REVISION="v0"
OPENWRT_RELEASE="openmptcprouter v0.59.1-5.4 r0+16594-ce92de8c8c"
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity
dhgutteridge commentedon Mar 22, 2024
I don't have an OpenMPTCProuter or OpenWrt environment to test with,
but searches suggest there is a BusyBox non-GNU implementation of awk
included. That wouldn't get picked up with the present assumptions that
some pkgsrc tooling makes. I don't know if that BusyBox version would
be adequate anyway, as various others don't meet pkgsrc expectations.
It's probably simplest to force use of nawk here. Please try this
patch.
(Now, I'm also not sure if it's best to just handle OpenWrt and
derivates, or search for a BusyBox indicator instead, etc., but this
should be a starting point. According to BusyBox documentation, their
grep should handle the options I applied.)
You may also find the BusyBox sed implementation is inadequate (though,
from browsing the documentation, it seems it may be fine), in which
case you'd also need to add another line with "need_sed=yes" as well.
(Depending on when you last pulled from GitHub, you'd also need to
update textproc/nbsed first, as it may not build for you without a fix
I applied on the 20th.)
Dave
jwbowen commentedon Mar 24, 2024
sskras commentedon Mar 24, 2024
@dhgutteridge commented 2 days ago:
True:
Can you be more specific, please? I tried looking into
mk/tools/tools.Linux.mk:... but I don't understand a thing yet. :)
The BusyBox version seems to be a mix of features of
nawk,gawkand whatnot:https://wiki.alpinelinux.org/wiki/Awk
Thanks, but before that I would like to understand the picking algorithm. Especially:
/usr/pkg/bin/nawkwill be present come from?AWKvariable left uninitialized?(Which leads to several
sh: -f: not founderrors near the end)BTW,
grephandles this fine.Tried going with
-A dforbmake:... but that left me overwhelmed with the output (which increased from 79k to 30M in size).
Any ideas on how to proceed with finding the root causes?
dhgutteridge commentedon Mar 25, 2024
Sorry, I think we're coming with different ideas of what was intended. My assumption was your primary interest was bootstrapping and using pkgsrc ASAP. It's probable you will encounter further issues as you go, so it could turn into a more protracted process to walk through every question that arises. The simple answer without getting into a lot of details is that "stuff will break" if bootstrapping goes awry. You may find make components behave inconsistently, as you see here (${AWK} evaluating to nothing, or to an unexpected default). This is code written by different people at different times.
Yes, some of this could be handled better; I'm not arguing otherwise. If you'd like to have a detailed technical review, that's a perfectly fine thing to request, but it's not something I can prioritize, I'm afraid.
sskras commentedon Mar 25, 2024
@dhgutteridge, thanks for making things clear!
I thought about progressing ASAP at first. But the delay in responses made me to consider doing an RCA. Which I think is still a good thing to do in most cases.
Fair enough. I am willing to do the research myself, but I need some (at least initial) guidance. It's hard to notice the moment where bootstrapping starts missing something and diverges from the plan.
I'll file a new issue to walk through that in parallel. Or maybe discussing it online like on IRC would be better? I already started a talk on that with @jperkin.
Now back to testing your fix.
sskras commentedon Mar 25, 2024
I tried to take the hint from @jwbowen into account:
... and the error changed:
Now it misses
cc, although the above steps likeBootstrapping bmakeandBuilding libnbcompatdealt with noccjust fine.Is having a
ccor${CC}defined a requirement of pkgsrc? Maybe just another, minor bug?sskras commentedon Mar 25, 2024
Now after defining
CC=gccpkgsrc gets into some circular dependency:dhgutteridge commentedon Mar 27, 2024
You haven't shared a complete log, so it's hard to know what's going on in entirety (e.g., with the other two packages that already built). This implies the individual packages have different expectations, but I haven't walked through them.
dhgutteridge commentedon Mar 27, 2024
This is a different issue entirely, and one I'm pretty sure isn't specific to your platform/setup. I think it could be reproducible elsewhere. I will look into that aspect.
dhgutteridge commentedon Mar 27, 2024
This could also relate to #124.
dhgutteridge commentedon Apr 12, 2024
Was the solution in #124 any help to you?
I wasn't able to reproduce this. I thought a relatively recent change might have created a condition where this could occur (on NetBSD), but it seems not. I'm familiar with situations where this pattern can occur, but I doubt they are relevant to you. (E.g., if someone confuses overriding WRKDIR when they really want WRKOBJDIR, they would get this circular dependency.)
sskras commentedon Apr 12, 2024
IIRC it helped. I wanted to file a related bug about pkgsrc not indicating that
hostnameis missing (and trying to build coreutils instead). IMO it's fair check to do.Is that (detection) doable – what do you think, David?
PS. Where did you try reproducing it BTW?
dhgutteridge commentedon Apr 12, 2024
Detection is certainly possible. I'm not sure that's the best solution, would need understand it better. Evidently some Linux distros don't include hostname by default. Hard to support N number of Linux distros, each with their own ideas of things. (Doesn't scale well with the small number of pkgsrc developers.) "uname -n" would perhaps be a better choice (i.e. patch the problem software instead of introducing another dependency), but there may be conflicting historical reasons why that wasn't done.
In general, IMO it's not realistic to expect pkgsrc to just work out of the box on any Linux distro without installing certain things in the base system (as opposed to requiring them to build during a bootstrap). Some of this is documented in README.Linux.
NetBSD 9.3_STABLE, which isn't a true "bootstrap" at all (under typical usage), but will pull in that dependency chain when someone starts from scratch. Thought I'd encountered a cyclical problem there back in February, but couldn't reproduce it now.
[-]Bootstrapping misses nawk on OpenMPTCProuter v0.59 (a build of OpenWRT)[/-][+]Bootstrapping fails on OpenMPTCProuter v0.59 (a build of OpenWRT)[/+]textproc/hs-commonmark: Update to 0.2.6
104 remaining items
py-icalendar: update to 7.0.0.
devel/serie: update to 0.6.1
devel/mujs: update to mujs-1.3.9
devel/ruby-curses: update to 1.6.0
filesystems/fuse-bindfs: update to 1.18.4
p5-YAML-Syck: update to 1.45.
devel/ruby-marcel: update to 1.2.1
p5-XML-LibXML: update to 2.0213.
finance/rex: update to 0.2.7
net/xfr: update to 0.9.21
Update to 0.41
net/ttl: update to 0.22.0
pdsh: Update to 2.36
misc/rozi: update to 0.0.31
misc/rozi: update to 0.0.31