Skip to content

ci: use shared NVSkills team-request workflow to support fork PRs - #2100

Open
ramakrishnap-nv wants to merge 1 commit into
mainfrom
ci/nvskills-fork-support
Open

ramakrishnap-nv wants to merge 1 commit into
mainfrom
ci/nvskills-fork-support

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the inlined request job in request-nvskills-ci.yml with the shared NVIDIA/skills/.github/workflows/team-request.yml@main (current template from NVIDIA/nvskills-ci), which is what supports fork PRs.
  • Add ready_for_review to the pull_request types, as in the template.
  • Keep the existing non-blocking require-nvskills-ci status job.

Before fork PRs work

  • NVCARPS adds allow_fork_pull_requests: true (and release/26.10 to allowed_base_refs) for NVIDIA/cuopt in NVIDIA/nvskills-ci/config/onboarded-repositories.json
  • After merge, contributors sync their forks
  • Fork authors add svc-nvskills-signing as a write collaborator
  • Decide whether to make the validation check blocking in branch protection (currently non-blocking, see ci: make pr-test-summary and NVSkills CI checks non-blocking #1696)
  • Update skills/cuopt-developer/references/contributing.md (says skills PRs must not come from a fork) once the opt-in is live. Left out here because editing skills/ triggers re-signing.

Same-repo flows are unchanged.

🤖 Generated with Claude Code

Use NVIDIA/skills team-request.yml (current NVCARPS template) so fork PRs
can be validated once allow_fork_pull_requests is enabled for this repo.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner October 9, 2026 16:00
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/cuopt/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: a55ad4db-861e-454e-9f28-664b1e54a241

📥 Commits

Reviewing files that changed from the base of the PR and between 9f1d2c3 and dadf527.


📒 Files selected for processing (1)
  • .github/workflows/request-nvskills-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.



📝 Walkthrough

Walkthrough

The NVSkills CI request workflow adds ready_for_review to its pull-request events and delegates request processing to a reusable workflow. Fork-based pull requests are supported when the repository onboarding config enables allow_fork_pull_requests: true.

Changes

NVSkills CI request

Layer / File(s) Summary
Trigger and reusable workflow delegation
.github/workflows/request-nvskills-ci.yml
The workflow documents the onboarding setting for fork-based pull requests and adds the ready_for_review event. The request job retains its existing condition and calls team-request.yml with read-only contents, pull-request, and status permissions. It passes the dispatch token as a secret and removes the inline request-processing steps.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature


Merge Risk: ⚪ Minimal · up to dadf5

The CI request workflow now delegates to the shared reusable workflow. That workflow still restricts comment-triggered CI requests to admins and maintainers and cancels duplicate requests. No concrete merge-blocking risk was found; fork PR behavior depends on the onboarding prerequisites listed in the description.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: replacing the inline NVSkills request job with a shared workflow to support fork pull requests.
Description check Passed The description accurately explains the workflow replacement, the added pull_request event, retained status job, fork support prerequisites, and unchanged same-repository flows.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

CI Test Summary

⏭️ All 5 test job(s) skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant