Repository navigation
CI: Integrate cuda-pathfinder into the shared release workflow - #3046
Open
jpascucci-nv wants to merge 2 commits into
Open
jpascucci-nv wants to merge 2 commits into
jpascucci-nv wants to merge 2 commits into
Conversation
Summary Refs NVIDIA#3012. Integrate Pathfinder’s automated release process into release.yml, sharing documentation and artifact-upload jobs while preserving the release process for other products. - Preserve Pathfinder’s release-note checks, successful tag-triggered CI requirement, draft metadata, checkout-free publishing, and installation verification on TestPyPI and PyPI. - Require successful documentation before uploading assets or publishing packages. Finalize the Pathfinder GitHub release only after successful uploads and PyPI verification, without marking it as latest. - Reuse release-upload.yml for source archives, checksums, and validated wheels. Load Pathfinder validation tools from the workflow revision so older release tags remain supported. - Reduce duplication with YAML anchors for publishing and verification steps. - Preserve Pathfinder release serialization and default-branch enforcement for full releases, while supporting the shared dry-run mode. - Keep other products’ publishing behavior, upload concurrency, and manual GitHub release finalization unchanged. Rollout The existing release-cuda-pathfinder.yml remains unchanged during migration. Pathfinder’s trusted publishers on both PyPI and TestPyPI must authorize release.yml before its first full release. Retire the legacy workflow and publisher registrations afterward. Validation Workflow linting passes. Live workflow-dispatch and trusted-publishing validation remain outstanding.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe shared release workflow now supports full ChangesPathfinder shared release
Priority: ➖ Normal Change: Feature Merge Risk: ⚪ Minimal · up to The reviewed workflow has no identified merge-blocking issue. Configure the documented trusted publishers before the first full release.
Comment ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
- Review profile: CHILL
- Plan: Enterprise
- Run ID:
38efa48c-5bb5-4952-962c-50835eef5962
📒 Files selected for processing (3)
.github/RELEASE-core.md.github/workflows/release-upload.yml.github/workflows/release.yml
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
Contributor
|
Contributor
Author
|
successfully run dry-run of release cuda-pathfinder on this branch: https://github.com/NVIDIA/cuda-python/actions/runs/37968708482 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #3012.
Integrate Pathfinder’s automated release process into release.yml, sharing documentation and artifact-upload jobs while preserving the release process for other products.
Rollout
The existing release-cuda-pathfinder.yml remains unchanged during migration. Pathfinder’s trusted publishers on both PyPI and TestPyPI must authorize release.yml before its first full release. Retire the legacy workflow and publisher registrations afterward.
Validation
Workflow linting passes. Live workflow-dispatch and trusted-publishing validation remain outstanding.
Checklist