Repository navigation
Conversation
Signed-off-by: Ye Liu <yeliu@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Human Reviewers
The positive grouped-MLP dprob determinism test can reach a cuDNN Frontend wrapper that accepts
deterministic=Truebut explicitly refuses its configured kernel. On Rubin, its first backward raises the knownNotImplementedErrorbefore the test reaches its byte comparisons.Recognize that exact refusal around the first run and report the configuration as skipped. A successful first run continues through the existing fusion assertions and repeated byte comparisons. Other exception messages, exception types, and failures during later runs still fail the test.
flowchart LR subgraph before["Before"] B1["First deterministic run"] -->|"Known FE refusal"| B2["Test fails"] B1 -->|"Success"| B3["Repeated byte comparisons"] end subgraph after["After"] A1["Same first run"] -->|"Exact known refusal"| A2["Skip with FE reason"] A1 -->|"Success"| A3["Same repeated byte comparisons"] endThis changes test classification for an unsupported configuration. The full SM107 grouped-MLP replay preserves every passing case and changes only the known GLU failure to a reasoned skip. Full L0 coverage remains outstanding.
Agent Reviewers
main, baseeb3c860a4d3394b7eb5e21dba3021fa10782a52e; head04a275acb1084a476cee6d8cffcb06487ac5aeaa.tests/pytorch/test_grouped_mlp.py,TestGroupedMLPDeterminism.test_dprob_is_bit_exact_across_runs.NotImplementedErrorwith the complete reasondeterministic dprob is implemented only for the SM100 kernel without dbias. The handler surrounds the initial_run()assignment only. After unwrapping that handler, the complete file's AST matches the base.33f3b3561943fcd9dd2f544f67dc2dfd62efdc9eproduction binaries. The affected common/PyTorch production sources match the target base. FE 1.32.0, candidate source identity, native-library identities and process exit were checked in the test environment. This Python-only change required no native rebuild.L0_*and PR CI coverage remain outstanding.Type of change
Changes
Checklist
The affected full grouped-MLP suite passed as recorded above; the complete L0/PR matrix remains outstanding. This test-only correction does not change the documented product API. The PR remains draft pending human author review.