Skip to content

[JAX] Disable NCCL communicator splitting for attention CI - #3681

Merged
KshitijLakhani merged 3 commits into
NVIDIA:mainfrom
KshitijLakhani:klakhani/fix/jax-attention-ci-nccl-splitting
Oct 19, 2026
Merged

KshitijLakhani merged 3 commits into
NVIDIA:mainfrom
KshitijLakhani:klakhani/fix/jax-attention-ci-nccl-splitting

Conversation

@KshitijLakhani

@KshitijLakhani KshitijLakhani commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Avoid the cached communicator replacement hang in the L1 distributed attention test sequence while the XLA/NCCL lifecycle issue is investigated. Scope the workaround to the attention pytest process.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Avoid the cached communicator replacement hang in the L1 distributed
attention test sequence while the XLA/NCCL lifecycle issue is investigated.
Scope the workaround to the attention pytest process.

Signed-off-by: Kshitij Lakhani <33047503+KshitijLakhani@users.noreply.github.com>
@KshitijLakhani

Copy link
Copy Markdown
Collaborator Author

/te-ci jax L0 L1

@KshitijLakhani
KshitijLakhani marked this pull request as ready for review October 19, 2026 22:57
@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The change appears safe to merge.

Summary

Disables NCCL communicator splitting for the L1 JAX distributed attention pytest process to avoid the reported communicator replacement hang.

  • The attention CI run disables NCCL communicator splitting.

Reviews (1) · Last reviewed commit: "Merge branch 'main' into klakhani/fix/ja..." · Reviewed by Greptile

@jberchtold-nvidia jberchtold-nvidia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KshitijLakhani
KshitijLakhani merged commit a7b6c0c into NVIDIA:main Oct 19, 2026
12 checks passed
@fheinecke fheinecke added the 2.21 label Oct 22, 2026
fheinecke pushed a commit that referenced this pull request Oct 22, 2026
Avoid the cached communicator replacement hang in the L1 distributed
attention test sequence while the XLA/NCCL lifecycle issue is investigated.
Scope the workaround to the attention pytest process.

Signed-off-by: Kshitij Lakhani <33047503+KshitijLakhani@users.noreply.github.com>
(cherry picked from commit a7b6c0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants